Application Review Request: 4digits_1.0

[Allison Randal]

NOTE: This submission was sent through the MyApps process.

= Application Review For 4digits =

 * Name: Yongzhi Pan
 * Email: panyongzhi@@gmail.com
 * Application name: 4digits
 * Tagline: Guess the number!
 * Keywords: puzzle, game
 * Description: 4digits is a guess-the-number puzzle game. It's called Bulls and Cows. The game's objective is to guess a four-digit number in 8 times using as less time as possible.
 * License: GNU GPL v2
 * Support URL: http://fourdigits.sourceforge.net/
 * Package file (link):
 * Images (links):
   * 64x64: https://myapps.developer.ubuntu.com/site_media/icons/2011/09/4digits_logo.png

=== Status ===

Pending review

[Allison Randal (allison)]

Thanks for submitting your app for Ubuntu! We're starting up the review
now. Has your app ever been packaged for Ubuntu or Debian before? If
not, we can help you get started on packaging it.

You may want to track the status of your app in review through the
Launchpad ticket:

https://bugs.launchpad.net/ubuntu-app-review-board/+bug/861480

Feel free to contact us (<email address hidden>) with any
questions, or reply to this email.

Thanks!
Allison

[周成瑞 (e93b5ae3)]

The game 4digits used to be in Debian and Ubuntu 7.10. Later it is
orphaned in Debian (no maintainer) and then removed from Ubuntu for
the same reason. For the current version, there is no deb package and
I do not know how to package it. If your team can help packaging it,
it would be great. Thanks!

[Allison Randal (allison)]

Great, so we can update the old packaging for the new version of 4digits and carry on, instead of starting from scratch. Here's the old version of the package:

https://code.launchpad.net/~ubuntu-branches/ubuntu/intrepid/4digits/intrepid

And, happy to help with getting it updated and ready to go. Looks like a pretty straightforward package, so you won't have much trouble learning how to maintain the packaging. We'll walk you through it.

[Allison Randal (allison)]

Hi, just to give you an update, I'm working on retrieving the old debian packaging today. You can see the work in progress in a temporary github repository I created at:

https://github.com/allisonrandal/pkg-4digits

[周成瑞 (e93b5ae3)]

Thank you Allison. If you have anything for me to do, please tell me.

[Allison Randal (allison)]

The git repository for Debian packaging for 4digits is now up-to-date. And, I've submitted the updated package to mentors.debian.net for consideration:

http://mentors.debian.net/package/4digits

I'm getting one libglade warning:

(4digits:27265): libglade-WARNING **: could not find glade file '/usr/games/4digits.glade'

I installed 4digits.glade in /usr/share/4digits/4digits.glade, which is a standard install location, and seems to be one of the places your 4digits python script is looking for the .glade file. Probably ignorable, so just an FYI.

Also, Lintian flagged one non-critical warning about your file 4digits.desktop, which is that the Encoding entry is no longer needed. You can see more details at:

http://lintian.debian.org/tags/desktop-entry-contains-encoding-key.html

[周成瑞 (e93b5ae3)]

On Sun, Nov 13, 2011 at 11:30 AM, Allison Randal <email address hidden> wrote:
> The git repository for Debian packaging for 4digits is now up-to-date.
> And, I've submitted the updated package to mentors.debian.net for
> consideration:
>
> http://mentors.debian.net/package/4digits
>
> I'm getting one libglade warning:
>
> (4digits:27265): libglade-WARNING **: could not find glade file
> '/usr/games/4digits.glade'
>
> I installed 4digits.glade in /usr/share/4digits/4digits.glade, which is
> a standard install location, and seems to be one of the places your
> 4digits python script is looking for the .glade file. Probably
> ignorable, so just an FYI.

This is due to the clumsy way it searches glade files. I will improve
it in future versions.
>
> Also, Lintian flagged one non-critical warning about your file
> 4digits.desktop, which is that the Encoding entry is no longer needed.
> You can see more details at:
>
> http://lintian.debian.org/tags/desktop-entry-contains-encoding-key.html

I have updated the desktop file. Thank you for the information.
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/861480
>
> Title:
>  Application Review Request: 4digits_1.0
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu-app-review-board/+bug/861480/+subscriptions
>

[Allison Randal (allison)]

4digits has been submitted to the Debian NEW queue, which is the next stage in getting it into Debian.

One additional bug report (from the Debian sponsor, I can't duplicate it on my Debian machines), he can't quit the game because of the following error:

IOError: [Errno 2] No such file or directory: '/home/clint/.4digits/prefs.pickle'

[Allison Randal (allison)]

In 4digits python script, in the 'write_preferences_file' function, you can test if the ~/.4digits directory exists before you open ~/.4digits/prefs.pickle for writing (line 183). If it doesn't exist, you can create it first.

I tried deleting the ~/.4digits directory and got the same error he did, and tried adding just an empty ~/.4digits directory and that eliminated the error.

[周成瑞 (e93b5ae3)]

On , Allison Randal <email address hidden> wrote:
> In 4digits python script, in the 'write_preferences_file' function, you

> can test if the ~/.4digits directory exists before you open

> ~/.4digits/prefs.pickle for writing (line 183). If it doesn't exist, you

> can create it first.

> I tried deleting the ~/.4digits directory and got the same error he did,

> and tried adding just an empty ~/.4digits directory and that eliminated

> the error.

I have updated the code that way. Thank you for it.

> To manage notifications about this bug go to:

> https://bugs.launchpad.net/ubuntu-app-review-board/+bug/861480/+subscriptions

[周成瑞 (e93b5ae3)]

I have fixed this bug and released a new version. Hopefully this will not occur. Change log is here:

http://fourdigits.sourceforge.net/ChangeLog

Just for your information in case work should be done on the new version.

[Allison Randal (allison)]

Would you like to try out this version yourself? It's pretty straightforward if you're running Ubuntu or Debian . Just click "Fork" on the github packaging repository I created:

https://github.com/allisonrandal/pkg-4digits

Check out your own fork, together with the packaging branches it includes:

git clone <email address hidden>:fossilet/pkg-4digits.git
git checkout -b upstream origin/upstream
git checkout -b pristine-tar origin/pristine-tar
git checkout master

You can check this worked by listing the git branches, which should look like this example:

allison@se:~/projects/git/pkg-4digits$ git branch
* master
  pristine-tar
  upstream

Install a couple of packaging tools:

sudo apt-get install git-buildpackage pristine-tar

Tell git to import the new release (it'll download the release from your site automatically):

git import-orig --pristine-tar --uscan

Edit the debian/changelog file and add these lines (update the date/time):
-----------
4digits (1.1-1) unstable; urgency=low
  * New upstream release.

 -- Yongzhi Pan <email address hidden> Fri, 09 Dec 2011 12:33:39 -0800
-----------

Commit that change, then push all the changes back to github:

git push origin master --tags
git push origin upstream --tags
git push origin pristine-tar --tags

Let me know when that's done, and I'll get it up to Debian.

[Allison Randal (allison)]

Oh, BTW, I noticed that 4digits has been sync'd to Ubuntu Precise now, so you'll be in the next release. We can also request a backport to Oneiric and Natty.

[周成瑞 (e93b5ae3)]

I am working as you told in master branch. When I am doing the push,
git asks for username and password, I provided my github ones. It
gives me such errors:

error: The requested URL returned error: 403 while accessing
https://github.com/allisonrandal/pkg-4digits/info/refs

fatal: HTTP request failed

I do not exactly what these commands does really.

[Allison Randal (allison)]

I took a look at github and your fork looks good.

The URL in the error says "allisonrandal", so your git checkout still thinks it should push (upload) to my github repository. You can check this with the command:

git remote -v

Which on mine says:
origin <email address hidden>:allisonrandal/pkg-4digits.git (fetch)
origin <email address hidden>:allisonrandal/pkg-4digits.git (push)

But on yours should say:
origin <email address hidden>:fossilet/pkg-4digits.git (fetch)
origin <email address hidden>:fossilet/pkg-4digits.git (push)

If that is the problem, you can fix it by running this command from inside the pkg-4digits directory, to change where git is pushing to:

git remote set-url origin <email address hidden>:fossilet/pkg-4digits.git

Don't worry if you don't understand it all yet, doing is the best way to learn, and you'll understand more as you go along. :) Ask any questions about the steps, and I can explain in more detail or point you to good resources.

[周成瑞 (e93b5ae3)]

I have committed it. Is that all right?

I think what I did can be roughly concluded as below: I cloned the
three branches from your repository, changed changelog file in master
branch, updated somehow the other two branches, and committed the
changes to my fork. Is it right?

On Sat, Dec 10, 2011 at 4:55 AM, Allison Randal <email address hidden> wrote:
> Would you like to try out this version yourself? It's pretty
> straightforward if you're running Ubuntu or Debian . Just click "Fork"
> on the github packaging repository I created:
>
> https://github.com/allisonrandal/pkg-4digits
>
> Check out your own fork, together with the packaging branches it
> includes:
>
> git clone <email address hidden>:fossilet/pkg-4digits.git
> git checkout -b upstream origin/upstream
> git checkout -b pristine-tar origin/pristine-tar
> git checkout master
>
> You can check this worked by listing the git branches, which should look
> like this example:
>
> allison@se:~/projects/git/pkg-4digits$ git branch
> * master
>  pristine-tar
>  upstream
>
> Install a couple of packaging tools:
>
> sudo apt-get install git-buildpackage pristine-tar
>
> Tell git to import the new release (it'll download the release from your
> site automatically):
>
> git import-orig --pristine-tar --uscan
>
> Edit the debian/changelog file and add these lines (update the date/time):
> -----------
> 4digits (1.1-1) unstable; urgency=low
>  * New upstream release.
>
>  -- Yongzhi Pan <email address hidden>  Fri, 09 Dec 2011 12:33:39 -0800
> -----------
>
> Commit that change, then push all the changes back to github:
>
> git push origin master --tags
> git push origin upstream --tags
> git push origin pristine-tar --tags
>
> Let me know when that's done, and I'll get it up to Debian.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/861480
>
> Title:
>  Application Review Request: 4digits_1.0
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu-app-review-board/+bug/861480/+subscriptions

[Allison Randal (allison)]

I'm closing this ticket, we'll continue talking by email. Thanks for the update to the debian package, I'll review it this afternoon!

[周成瑞 (e93b5ae3)]

Hi Allison,

I have updated the debian source package. I build and tested on my machine.
Can you have a look at it? If it is OK, can you upload to debian FTP?
Thanks.

Best regards,

Yongzhi

On Wed, Jan 11, 2012 at 11:52 PM, Allison Randal <email address hidden>wrote:

> I'm closing this ticket, we'll continue talking by email. Thanks for the
> update to the debian package, I'll review it this afternoon!
>
> ** Changed in: ubuntu-app-review-board
> Status: New => Fix Released
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/861480
>
> Title:
> Application Review Request: 4digits_1.0
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu-app-review-board/+bug/861480/+subscriptions
>