Need to recursively search pids when detecting if pid is in a cgroup
Bug #1386357 reported by
Christopher Townsend
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Application Launcher |
Fix Committed
|
Medium
|
Christopher Townsend | ||
| ubuntu-app-launch (Ubuntu) |
Fix Released
|
Medium
|
Christopher Townsend | ||
Bug Description
When searching through the list of pids to detect if they are in the cgroup we care about, u-a-l currently only gets the top pid due to calling GetTasks. Instead, we should call GetTasksRecursive to get the whole list.
This is needed when trying to start up X applications inside a container using XMir.
Related branches
lp:~townsend/ubuntu-app-launch/fix-lp1386357
- PS Jenkins bot (community): Approve (continuous-integration)
- Ted Gould (community): Approve
-
Diff: 101 lines (+14/-14)3 files modifiedhelpers-shared.c (+1/-1)
tests/cgroup-reap-test.cc (+3/-3)
tests/libual-test.cc (+10/-10)
- PS Jenkins bot (community): Approve (continuous-integration)
- Indicator Applet Developers: Pending requested
-
Diff: 101 lines (+14/-14)3 files modifiedhelpers-shared.c (+1/-1)
tests/cgroup-reap-test.cc (+3/-3)
tests/libual-test.cc (+10/-10)
| Changed in ubuntu-app-launch: | |
| status: | New → In Progress |
| Changed in ubuntu-app-launch (Ubuntu): | |
| status: | New → In Progress |
| Changed in ubuntu-app-launch: | |
| importance: | Undecided → Medium |
| description: | updated |
| Changed in ubuntu-app-launch: | |
| assignee: | nobody → Christopher Townsend (townsend) |
| Changed in ubuntu-app-launch (Ubuntu): | |
| importance: | Undecided → Medium |
| assignee: | nobody → Christopher Townsend (townsend) |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-app-launch (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-app-launch: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
This bug was fixed in the package ubuntu-app-launch - 0.4+15.
---------------
ubuntu-app-launch (0.4+15.
[ Chris Townsend ]
* Change GetTasks to GetTasksRecursive so it searches all pids related
to a cgroup instead of just the first pid. (LP: #1386357)
[ Leo Arias ]
* On the cgroup manual test, make it clear that the command must be
run on the app.
-- Ubuntu daily release <email address hidden> Fri, 31 Oct 2014 15:02:48 +0000