Two underscores in .desktop file name causes assumption that this is an appId and app is rejected.

[Leo Arias]

On the daily image testing for mako, image#78, one of the lifecycle management tests in unity failed because of a qmlscene crash (see attachment).

21:15:34.162 INFO _launcher:116 - Attempting to launch application 'tmp991xm1vf' with URIs '' via upstart-app-launch
21:15:36.367 INFO _launcher:116 - Attempting to launch application 'tmpbeb_op_3' with URIs '' via upstart-app-launch
21:16:08.689 ERROR _launcher:202 - Timed out waiting for Application with app_id 'tmpbeb_op_3' to stop.

http://ci.ubuntu.com/smokeng/utopic/touch/mako/78:20140611.1:20140530/8530/unity8/1241528/

[Ted Gould (ted)]

Doesn't look like something UAL would be effecting. Seems to be a crash in the QML Scene binary itself.

[Leo Arias (elopio)]

Marking as incomplete because the crash file lacks information. Andy is hacking the phablet-test-run script to run whoopsie-collect-all after the tests.

[Leo Arias (elopio)]

This has happened again on image #124.

http://ci.ubuntu.com/smokeng/utopic/touch/mako/124:20140710.1:20140709/8982/unity8/1354177/

Attached is the crash.
The application log only says:
QUbuntu: Could not create application instance

[Timo Jyrinki (timo-jyrinki)]

Retraced at bug #1340571 - leans towards qtubuntu.

[Leo Arias (elopio)]

Thanks Timo. I'm seeing qmlscene crashes more often this week, so it would be nice if somebody can investigate.

[Tim Peeters (tpeeters)]

We get a lot of failures in autolanding lately, with errors like:

  File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 331, in _init
    raise NoSuchProcess(pid, None, msg)
NoSuchProcess: no process found with pid 4908

See https://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2289/testReport/junit/ubuntuuitoolkit.tests.custom_proxy_objects.test_textfield/TextFieldTestCase/test_select_all_selects_all_text/

Is it caused by this bug?

[Tim Peeters (tpeeters)]

We have almost all of our MRs failing on autolanding with NoSuchProcess errors so I confirmed the bug and changed the importance to Critical. If someone more knowledgable about this issue thinks it is another bug, please let me know (timp/t1mp on irc).

[Alexandros Frantzis (afrantzis)]

The crash as retraced in https://bugs.launchpad.net/ubuntu/+bug/1340571 , is caused by qtubuntu not being able to connect to the mir server/shell. It doesn't necessarily indicate there is a problem in qtubuntu (of course it doesn't preclude it either). For example you would get the same "crash" if the server had died.

[Leo Arias (elopio)]

To reproduce the crash on mako:

$ phablet-shell
$ sudo mount -o remount,rw /
$ sudo apt-get install ubuntu-ui-toolkit-autopilot
$ wget https://bugs.launchpad.net/ubuntu-app-launch/+bug/1329141/+attachment/4155946/+files/test.py
$ while autopilot3 run test; do :; done

I've just run it on a freshly flashed mako with devel-proposed, and it failed in 3 minutes.

[Gerry Boland (gerboland)]

The output of unity8.log would help, as it would show if unity8 rejected the client connection (and thus causing client to crash) or not. That's usually the reason for this error.

[Cris Dywan (kalikiana)]

This one crashed like that, but I can't seem to get the logs out of it https://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2304/

[Michał Sawicz (saviq)]

After running the test for 15 mins or so I got the log, attached.

[Michał Sawicz (saviq)]

OK I think I found what happens here:

WARNING: long App ID encountered: tmpu_5uhy_8

** (process:2551): WARNING **: Unable to get manifest for 'tmpu' package: tmpu does not exist in any database for user phablet

** (process:2551): CRITICAL **: manifest_version: assertion '*manifest != NULL' failed

** (process:2551): CRITICAL **: ubuntu_app_launch_triplet_to_app_id: assertion 'version != NULL' failed
ApplicationManager REJECTED connection from app with pid 13154 as desktop_file_hint file not found

The random tmp application name sometimes includes underscores, and at some point it randomizes to two underscores, at which point it's assumed that this is an app id and things go haywire.

Simple solution: stop the tmp app name from having underscores.

Needs investigation: can we be more robust in unity-mir/unity8 here?

[Michał Sawicz (saviq)]

The temp file is created in:
http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/view/head:/tests/autopilot/ubuntuuitoolkit/fixture_setup.py#L84

Unfortunately NamedTemporaryFile does not let you to tell it not to use underscores... We should be able to rename it after creation, though. It's not a great solution unfortunately.

We still need to verify what caused this to start happening.

[Michał Sawicz (saviq)]

To reproduce with the two attached files:

$ qmlscene foo_bar_baz.qml --desktop_file_hint=$PWD/foo_bar_baz.desktop

[Leo Arias (elopio)]

Wow, intersting. Thanks for the investigation saviq.
Christian's branch is looking good as a workaround.

[Alejandro J. Cura (alecu)]

A simpler solution might be to remove _ from the list of chars that tempfile uses to create filenames, with something like:
tempfile._RandomNameSequence.characters = tempfile._RandomNameSequence.characters.strip("_")

It seems to work ok: http://pastebin.ubuntu.com/7831443/

[Ted Gould (ted)]

We're using whether the click hook created a link for us to determine whether it's a click package today, so I think this is fixed.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.