"Depends" choices when edit an AccomplishmentProposal

Bug #963902 reported by Denis Darii
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Accomplishments Web Gallery
Fix Released
Undecided
Denis Darii

Bug Description

In "edit accomplishment" form we filter Accomplishment.objects.filter(application=accom.application) for "depends" choices.

My question is: can an AccomplishmentProposal "depend" on their own "parent" Accomplishment?

or we must add an exclude for "Depends" select:

Accomplishment.objects.filter(application=accom.application).exclude(pk=accom.pk)

Let me know.

Revision history for this message
Denis Darii (dnx) wrote :
Revision history for this message
Janos Gyerik (janos-gyerik) wrote :

True, a proposal depending on its parent accomplishment would mean an accomplishment depending on itself which doesn't make sense. An accomplishment can depend on other accomplishments or depend on depend on nothing, but not depend on itself.

Thanks for spotting it!

Changed in ubuntu-accomplishments-web-editor:
status: New → Confirmed
assignee: nobody → Denis Darii (dnx)
Denis Darii (dnx)
Changed in ubuntu-accomplishments-web-editor:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.