Can't open Accomplished Trophy

Bug #940376 reported by Winael
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu Accomplishments System
Fix Released
Wishlist
Rafał Cieślak

Bug Description

Hi

There's a bug I had yesterday. I try to open one of my Trophees just to see the information related to it. But when I click on it, nothing happened.

I think it could be great to still have some information about the Accomplishment linked to the Trophee, with maybe a share to social network link

BR,
Winael

Related branches

Revision history for this message
Jono Bacon (jonobacon) wrote :

Currently the GUI does not support this. Marking as Wishlist.

Changed in ubuntu-accomplishments-system:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Simon Watson (simon-swat) wrote :

What sort of information would we want?

Revision history for this message
Winael (vinzjobard) wrote :

Hi

Well When I filled this bug I thank about the accomplishments informations we had in .accomplishment file.

What do you think about it ?

BR

Revision history for this message
Jono Bacon (jonobacon) wrote :

My hunch is that we instead read in the contents of the .trophy file that is generated. This way we can add useful information about the trophy that was accomplished, e.g:

 * The data it was accomplished.
 * The person who accomplished (e.g. with which email address for the Ubuntu accomplishments).

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

I've pushed my suggested fix to lp:~rafalcieslak256/ubuntu-accomplishments-system/fix-940376
It generates a trophy info using the .trophy file. I've re-used the code that generates information concerning achievement opportunities, so this is a small fix.

Changed in ubuntu-accomplishments-system:
assignee: nobody → Rafal Cieslak (rafalcieslak256)
Revision history for this message
Jono Bacon (jonobacon) wrote :

Thanks to Rafal for the merge proposal to fix this - I have just asked if Rafal can re-base the merge proposal on the current code (as I merged in Duncan's branch which re-factored some bits of the code).

As such, assigning this to Rafal and setting as In Progress.

Changed in ubuntu-accomplishments-system:
status: Confirmed → In Progress
Revision history for this message
Jono Bacon (jonobacon) wrote :

After some thinking, I think the goal of this bug fix should be to show useful information about the nature and conditions of how the trophy was accomplished.

My hunch here is that you show the orange bar that is currently shown in the Opportunity information documentation and you show:

 * The trophy icon.
 * The name of the trophy (e.g. Reported First Bug).
 * The trophy summary (e.g. You reported your first bug in Ubuntu.)
 * The date the trophy was accomplished.
 * The identity of the person who accomplished it.

All of this information can be gathered from the .trophy.asc file that is present in ~/.local/share/accomplishments/trophies/ubuntu-community

For the date of the accomplishment this could be gathered from the timestamp of the .trophy.asc file.

for the identify of the person, this is the unique extra-information content that we use to verify the file. If you look at a .trophy.asc file you can see the following two example fields from one of my accomplishments:

needs-information = launchpad-email
launchpad-email = <email address hidden>

As you can see the extra-information is specified in the 'needs-information' key which tells us what the information required is. This then acts as a key elsewhere in the file which then tells us the email address.

To find the human readable label for launchpad-email (or whatever other kind of needs-information you will need to look in <accomplishmentsdir>/accomplishments/<application>/extrainformation/launchpad-email

(you can find the `application` also in the .trophy.asc file)

Make sense?

Jono Bacon (jonobacon)
Changed in ubuntu-accomplishments-system:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.