Daemon code cleanup

[Duncan McGreggor]

There are a bunch of things should should be cleaned up in the daemon code. At a quick glance, they include the following:
 * lines longer than 79 chars
 * mixed lowerCamelCase and under_score for method names
 * incorrect newline counts between module-level code
 * incorrect indentation of code that continues onto next line (e.g., list comprehensions and parens)

[Jono Bacon (jonobacon)]

Are these pieces to ensure it is inline with PEP-8?

[Duncan McGreggor (oubiwann)]

PEP8 and other best practices, yes. (But mostly PEP8.)

[Jono Bacon (jonobacon)]

Makes sense.

[Nicolas Valcarcel (nvalcarcel)]

Working on this

[Rafał Cieślak (rafalcieslak256)]

Please do not mark this bug as "Fix committed", as it annotates that the fix is ready in trunk and bug can be considered as fixed, which is not yet the case.

[Jono Bacon (jonobacon)]

What is the current status of this bug - Rafal, do you consider that your recent work fixes this?

[Rafał Cieślak (rafalcieslak256)]

Definitely not, most likely it is even worse now ;-)
That branch linked to this bug could not be merged in (details in MP comments). I am not a python expert, but I expect there exists some automatic tool that does this work.
Anyway, this has to be redone for current code state, if we want to maintain PEP8 correctness.

[Jono Bacon (jonobacon)]

Agreed.

Maybe we could organize a short sprint one day and try and get all of this fixed. We can also tidy up the 'accom/accomplishment/acc' references that Matt outlined in https://bugs.launchpad.net/ubuntu-accomplishments-daemon/+bug/1024015

[Nicolas Valcarcel (nvalcarcel)]

i'll work on it. It's more of tools + trained eye to get it right.

On Sun, Jul 29, 2012 at 3:23 PM, Jono Bacon <email address hidden> wrote:
> Agreed.
>
> Maybe we could organize a short sprint one day and try and get all of
> this fixed. We can also tidy up the 'accom/accomplishment/acc'
> references that Matt outlined in https://bugs.launchpad.net/ubuntu-
> accomplishments-daemon/+bug/1024015
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/947271
>
> Title:
> Deamon code cleanup
>
> Status in Ubuntu Accomplishments Daemon:
> Triaged
>
> Bug description:
> There are a bunch of things should should be cleaned up in the daemon code. At a quick glance, they include the following:
> * lines longer than 79 chars
> * mixed lowerCamelCase and under_score for method names
> * incorrect newline counts between module-level code
> * incorrect indentation of code that continues onto next line (e.g., list comprehensions and parens)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu-accomplishments-daemon/+bug/947271/+subscriptions

--
aka nxvl
Yo uso Software Libre, y tu?

[Matt Fischer (mfisch)]

Is this bug still being worked on?

[Nicolas Valcarcel (nvalcarcel)]

I runned out of time, but i don't mind setting up a call or something
to teach you how to follow pep8

On Fri, Aug 17, 2012 at 11:52 AM, Matt Fischer
<email address hidden> wrote:
> Is this bug still being worked on?
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/947271
>
> Title:
> Deamon code cleanup
>
> Status in Ubuntu Accomplishments Daemon:
> Triaged
>
> Bug description:
> There are a bunch of things should should be cleaned up in the daemon code. At a quick glance, they include the following:
> * lines longer than 79 chars
> * mixed lowerCamelCase and under_score for method names
> * incorrect newline counts between module-level code
> * incorrect indentation of code that continues onto next line (e.g., list comprehensions and parens)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu-accomplishments-daemon/+bug/947271/+subscriptions

--
aka nxvl
Yo uso Software Libre, y tu?

[Matt Fischer (mfisch)]

Using autopep8 to fight this beast. After some analysis, I will fix all but long lines which are used extensively for showing output in the docs and will need more careful analysis.