parsing errors in an accomplishment file will crash the daemon
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Accomplishments Daemon |
Fix Released
|
High
|
Matt Fischer |
Bug Description
If you have 1 accomplishment file with a parse error the whole daemon will crash. I think that logging the bad accomplishment and moving on to the next one is a better solution:
It will crash reload_
File "../../
accomcfg.
File "/usr/lib/
self._read(fp, filename)
File "/usr/lib/
raise e
ParsingError: File contains parsing errors: /tmp/tmp8ZeCDd/
[line 2]: 'descriptionbad desc\n'
Here's my simple bad accomplishment:
[accomplishment]
descriptionbad desc
Related branches
- Ubuntu Accomplishments Daemon Developers: Pending requested
-
Diff: 239 lines (+51/-49)2 files modifiedaccomplishments/daemon/api.py (+38/-20)
accomplishments/daemon/tests/tests.py (+13/-29)
Changed in ubuntu-accomplishments-daemon: | |
assignee: | nobody → Rafal Cieślak (rafalcieslak256) |
Changed in ubuntu-accomplishments-daemon: | |
milestone: | none → 0.3 |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntu-accomplishments-daemon: | |
assignee: | Rafal Cieślak (rafalcieslak256) → Matt Fischer (mfisch) |
status: | Confirmed → In Progress |
Changed in ubuntu-accomplishments-daemon: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-accomplishments-daemon: | |
status: | Fix Committed → Fix Released |
Note:
When this is fixed the unittest test_bad_ accomplishment_ list() needs to be re-enabled and the unit test test_bad_ accomplishment_ parse() needs to be removed.