Counters should be thread safe

[Lucio Torre]

counters do:

self._count += value

in increment. this should be made thread safe so this can be called from any thread and not have to manage the serialization of calls outside of it.

[Robert Collins (lifeless)]

On Sat, Oct 1, 2011 at 7:29 AM, Lucio Torre <email address hidden> wrote:
> Public bug reported:
>
> counters do:
>
> self._count += value
>
> in increment. this should be made thread safe so this can be called from
> any thread and not have to manage the serialization of calls outside of
> it.

Thats a poor idea - taking a lock is /much/ more expensive than not,
and native twisted code is single threaded anyway.

I suggest you have a threaded version of the class, or something,
rather than penalising every caller. (Or is this in the server? if its
in the server, why is it threaded at all???)