s3/client.py should not depend on epsilon library

Bug #856067 reported by Daira Hopwood
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
txAWS
Fix Released
Low
Clint Byrum
txaws (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

s3/client.py has an import "from epsilon.extime import Time". It uses this only as "Time.fromISO8601TimeAndDate(date_text).asDatetime()", which returns a datetime.datetime object from the Python standard library (http://docs.python.org/library/datetime.html).

It doesn't make sense to pull in a fairly large external library (whose debian package depends also on python-nevow and python-openssl!), for such a small piece of functionality.

Related branches

Revision history for this message
Daira Hopwood (daira) wrote :

... and especially not when that library is unmaintained, after the demise of Divmod.

Changed in txaws:
status: New → Confirmed
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

This functionality is better handled by dateutil, which is well maintained and included in Ubuntu main. See attached merge proposal for a simple fix.

Thomas Herve (therve)
Changed in txaws:
importance: Undecided → Low
assignee: nobody → Clint Byrum (clint-fewbar)
status: Confirmed → Fix Committed
milestone: none → 0.3
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package txaws - 0.2-0ubuntu8

---------------
txaws (0.2-0ubuntu8) precise; urgency=low

  * d/patches/drop-epsilon.patch: Removes epsilon dependency in
    and switches to dateutil, which is already in main. (LP: #856067)
  * d/patches/drop-pytz.patch: Removes pytz dependency and
    switches to dateutil. (LP: #912589)
  * d/patches/drop-zope-datetime.patch: Removes zope.datetime
    dependency and switches to dateutil. (LP: #912607)
 -- Clint Byrum <email address hidden> Fri, 06 Jan 2012 09:37:54 -0800

Changed in txaws (Ubuntu):
status: New → Fix Released
Changed in txaws:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.