s3 multipart upload support

[Zooko Wilcox-O'Hearn]

I'm going to need this feature soon. I see that there is a branch with some patches on it: lp:~dkeeney/txaws/add-multipart-upload . Has anyone reviewed that branch? Where would I look in the launchpad user interface to find out if there is any discussion, code-reviews, or tickets about that branch? Thanks!

I guess #767205 may be related but I'm not yet sure.

[Jamu Kakar (jkakar)]

Zooko:

There have been no reviews for that branch. If there were you'd see
them on the branch's page, listed where it says 'Propose for merge'.
It looks like the last revisions where pushed in December, so it's not
clear if the branch is done or has stalled. I don't know where to
find it in the UI, but you can see the list of branches in the review
queue here:

https://code.launchpad.net/txaws/+activereviews

If you want to propose a branch for merge do these things:

1. File or find the bug that describes the issue your branch
   addresses.

2. Click 'Link a related branch' (in the right hand portal), find your
   branch with the search pop-up and select it.

3. Click on the branch that appears on the bug page.

4. Click 'Propose for merge'.

5. Write a comment describing the change your branch introduces.

6. Wait for reviews.

[Zooko Wilcox-O'Hearn (zooko)]

Okay, I read the patches on this branch: lp:~dkeeney/txaws/add-multipart-upload . The only problem I noticed is that the most recent changes -- http://bazaar.launchpad.net/~dkeeney/txaws/add-multipart-upload/revision/77 , http://bazaar.launchpad.net/~dkeeney/txaws/add-multipart-upload/revision/78 , and http://bazaar.launchpad.net/~dkeeney/txaws/add-multipart-upload/revision/79 -- don't have accompanying unit tests. It looks like to me from perusing the patches that this should be sufficient to support multipart upload to S3.

[Zooko Wilcox-O'Hearn (zooko)]

Oh, and also a lack of tests for all of the other changes in the branch. I would favor adding tests before merging, actually, so I guess I should now undo my "suggest merge" action?