Refactor txaws.storage to match the recent work in txaws.ec2

Bug #474353 reported by Duncan McGreggor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
txAWS
Fix Released
Medium
Duncan McGreggor

Bug Description

In the EC2 code, we have a client and a query object that is used with the client:
 * txaws.ec2.client.EC2Client
 * txaws.ec2.client.Query

In the S3 code, we should maintain a symmetry here, and thus do the following:
 * rename txaws.storage.client.S3Request -> Query
 * rename txaws.storage.client.S3 -> S3Client
 * find common code between txaws.ec2 and txaws.storage, and if there is any, factor that out to a txaws.query.Query class

Docs:
 * http://docs.amazonwebservices.com/AmazonS3/latest/
 * http://docs.amazonwebservices.com/AmazonS3/2006-03-01/API/index.html

Related branches

description: updated
Changed in txaws:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Duncan McGreggor (oubiwann)
description: updated
description: updated
Revision history for this message
Duncan McGreggor (oubiwann) wrote :

The refactor is complete, now. The next step is checking the new code against Amazon's service.

Changed in txaws:
milestone: none → 0.1
Revision history for this message
Duncan McGreggor (oubiwann) wrote :

Excellent! I've checked that all the currently supported features in txaws.s3 are working against Amazon (this required some fixes). I've pushed the changes and will do a pre-review, and then submit for review :-)

Revision history for this message
Duncan McGreggor (oubiwann) wrote :

Ready for review...

Revision history for this message
Duncan McGreggor (oubiwann) wrote :

  Merged 474353-storage-ec2-symmetry [r=lifeless] [f=474353]

  This change brought the storage subpackage (now renamed to s3) up to date with
  the ec2 subpackage (style, unit tests, idioms, error handling). This work
  included factoring out common code between ec2 and s3 and putting it in the
  base client.

Changed in txaws:
status: In Progress → Fix Committed
Changed in txaws:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.