Inconsistent Coding Standard Employed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Landscape Server |
Fix Released
|
Low
|
Duncan McGreggor | ||
txAWS |
Fix Released
|
Medium
|
Duncan McGreggor |
Bug Description
As mentioned in a recent email to the list, the naming convention used for
methods in txAWS is split between camelCase and standard PEP-8 usage.
This needs to be resolved as quickly as possible, since there's a good chance
we're going to start using this code at Canonical and adding more stuff to it
as time goes on. The coding standard needs to be consistent across the code
base..
Also, we want to make this kind of API-breaking change now, before the library
is used too widely to do this easily.
Grep'ing the code, it seems that the Twisted standard of camelCase is most
prominently used. As this is a Twisted project and this standard already holds
the majority, I propose to make the necessary changes in a new branch using the
Twisted standard.
Does anyone have any violent objections to this?
Related branches
- Robert Collins (community): Needs Fixing
- Jamu Kakar: Pending requested
- Thomas Herve: Pending requested
- Diff: None lines
Changed in txaws: | |
importance: | Undecided → Medium |
assignee: | nobody → Duncan McGreggor (oubiwann) |
Changed in landscape: | |
assignee: | nobody → Duncan McGreggor (oubiwann) |
importance: | Undecided → Low |
milestone: | none → 1.3.5 |
status: | New → Fix Committed |
tags: | added: needs-testing |
tags: | removed: needs-testing |
Changed in landscape: | |
status: | Fix Committed → Fix Released |
Changed in txaws: | |
status: | Fix Committed → Fix Released |
Well, its a project /for use with/ twisted - not the same thing as being
part of twisted at all. And the python standard - pep8 - discourages
camelCase.
I'd much rather not use camel case.
I doubt I'll get violent about it though.
-Rob