txAWS

fix edge case in computing hash for authorization at AWS

Bug #1033327 reported by Zooko Wilcox-O'Hearn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
txAWS
New
Medium
Zooko Wilcox-O'Hearn

Bug Description

There's a funky edge case in how AWS computes hashes for authorization that txAWS currently doesn't match. This patch is necessary for DevPay authorization for https://leastauthority.com . Warning: this patch was extracted by Zooko from the complete "LAE post4" patch set that we run in production at LAE. I'll also attach the complete patch set that we're running in production.

Revision history for this message
Zooko Wilcox-O'Hearn (zooko) wrote :
Revision history for this message
Zooko Wilcox-O'Hearn (zooko) wrote :
Revision history for this message
Zooko Wilcox-O'Hearn (zooko) wrote :

Here's the patch in bzr: http://bazaar.launchpad.net/~zooko/txaws/leastauthority.com/revision/153

Also I think the patch I attached to this ticket may have selected the wrong hunks from the overall "post4 LAE patch" and this patch I pushed into bzr may work better.

Revision history for this message
Thomas Herve (therve) wrote :

Hi, thanks for the patch. Some remarks:

 * It'd be nice to have a seperate branch with the changes, and push that up for review using the merge proposal system.
 * It needs tests.

Let me know if I can help.

Changed in txaws:
importance: Undecided → Medium
assignee: nobody → Zooko Wilcox-O'Hearn (zooko)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.