txamqp.protocol.AMQClient does not use the clock passed as an arg as the LoopingCall clock

Bug #996614 reported by cyli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
txAMQP
Fix Released
Undecided
Unassigned

Bug Description

I'm not entirely sure if this is a bug or if this was intended, but it seems like the clock that is passed in and used as the clock to check the heartbeat should be the same clock used to make the heartbeat.

clock.callLater is used, but LoopingCall is also used, without setting the clock of the looping call.

Also, this is not in the patch, but time.time() is used for the last heartbeat received and last heartbeat sent - if the actual seconds since the epoch don't need to be used, reactor/clock.seconds() can be used instead of time(). (For those who want to use the clock for timing).

Revision history for this message
cyli (cyli) wrote :
description: updated
description: updated
Changed in txamqp:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.