Too many blank lines, expected %s

Bug #1162202 reported by Jonathan Jacobs
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
twistedchecker
Fix Released
Undecided
HawkOwl

Bug Description

As of revision 29 of trunk, this warning appears to be missing an interpolation value.

Related branches

Revision history for this message
Tristan Seligmann (mithrandi) wrote :

It's supposed to be getting an interpolation value thanks to this regex:

        'E303': ('W9015', r'too many blank lines, expected \((\d+)\)'),

Unfortunately I don't know what is going wrong here.

HawkOwl (hawkowl)
Changed in twistedchecker:
status: New → Confirmed
Revision history for this message
HawkOwl (hawkowl) wrote :

Okay, so I've chucked up a branch to "fix" this.

'E303': ('W9015', r'too many blank lines, expected \((\d+)\)'),

^ that was incorrect, and should not have had ", expected" in it. This was only in the internal pep8 blank lines replacement, but that relies on monkey patching, which doesn't currently seem to work. This fixes the core problem in this ticket, though.

Changed in twistedchecker:
assignee: nobody → HawkOwl (hawkowl)
status: Confirmed → In Progress
Revision history for this message
HawkOwl (hawkowl) wrote :

I've pushed up another update to the branch to fix this fully.

It now properly monkeypatches PEP8. It also gets rid of some old compat stuff, which is not really needed, since PEP8 1.0 onwards supports this fine.

HawkOwl (hawkowl)
Changed in twistedchecker:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.