twisted.web.client._URI.fromBytes does not handle ipv6 addresses

Bug #1505748 reported by LaMont Jones
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Twisted
Unknown
Unknown
twisted (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Certainly by 13.2.0-1ubuntu1 (trusty), fromBytes blows up when handed an ipv6 address, because of an assumption that the only valid use of a colon is as part of a port specification. See also bug #1372767.

Patch attached which should fix the issue, though it is against 1:15.2.1-1ubuntu1, and needs a "s/URI/_URI/g" before it will apply to the trusty version.

Tags: patch wily
Revision history for this message
LaMont Jones (lamont) wrote :

attaching the correct patch

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Thanks for taking your time to report this issue and providing a patch.

I've assigned the ubuntu-reviewers team who will hopefully soon take a look at and review the patch.

Normal procedure is that patches are applied to the current development version of Ubuntu, and then possibly also for older releases. See details on the Stable Release Update procedure for more information on this https://wiki.ubuntu.com/StableReleaseUpdates.

tags: added: patch wily
Revision history for this message
LaMont Jones (lamont) wrote :

This is the actual and verified patch for 15.2.1-1ubutnu1

Revision history for this message
LaMont Jones (lamont) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package twisted - 15.2.1-1ubuntu2

---------------
twisted (15.2.1-1ubuntu2) wily; urgency=medium

  * web/client: allow IPv6 addresses. lp1505748.diff
    LP: #1505748

 -- LaMont Jones <email address hidden> Wed, 14 Oct 2015 11:00:28 -0600

Changed in twisted (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.