can not send notifier and RPC message in different rabbitMQ cluster

Bug #1734823 reported by wangjun
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
wangjun

Bug Description

I think notifier's and rpc's transports should be separated,just like this:

def init(conf):
    global TRANSPORT, NOTIFICATION_TRANSPORT
    global SENSORS_NOTIFIER, VERSIONED_NOTIFIER
    exmods = get_allowed_exmods()
    TRANSPORT = messaging.get_rpc_transport(conf,
                                            allowed_remote_exmods=exmods)
    NOTIFICATION_TRANSPORT = messaging.get_notification_transport(
        conf,
        allowed_remote_exmods=exmods)

    serializer = RequestContextSerializer(messaging.JsonPayloadSerializer())
    SENSORS_NOTIFIER = messaging.Notifier(NOTIFICATION_TRANSPORT,
                                          serializer=serializer)
    if conf.notification_level is None:
        VERSIONED_NOTIFIER = messaging.Notifier(NOTIFICATION_TRANSPORT,
                                                serializer=serializer,
                                                driver='noop')
    else:
        VERSIONED_NOTIFIER = messaging.Notifier(NOTIFICATION_TRANSPORT,
                                                serializer=serializer,
                                                topics=['ironic_versioned_'
                                                        'notifications'])

Changed in trove:
assignee: nobody → wangjun (wang.jun)
importance: Undecided → Medium
wangjun (wang.jun)
Changed in trove:
status: New → In Progress
Revision history for this message
wangjun (wang.jun) wrote :
Changed in trove:
status: In Progress → Fix Committed
Revision history for this message
Fan Zhang (fanzhang) wrote :

As I said in the patch's comment, what you were trying to do is that separating the destination of RPC calls and notifications. Now this title make me think that you are trying to send them into different rabbitmq clusters, which is little bit confusing.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/525361
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=1dcdf38bc207e54cca234788b144afb0da27b4e9
Submitter: Zuul
Branch: master

commit 1dcdf38bc207e54cca234788b144afb0da27b4e9
Author: wangjun <email address hidden>
Date: Tue Dec 5 09:40:53 2017 +0800

    Add functionality to define different Message and Notification destination

    Sometime,huge notification messages will effect the rabbitMQ cluster's
    performance.This commit adds functionality do define different Message
    and Notification destination.

    Closes-Bug: #1734823
    Change-Id: I2ef4d008c9ca91a03d8c7e1380e0188bf6792595

Changed in trove:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/trove 10.0.0.0b1

This issue was fixed in the openstack/trove 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.