Limit -1 in trove quota-show does not means unlimited like other projects

[Fan Zhang]

When I met "QuotaExceeded: Quota exceeded for resources: ['volumes']" earlier this day, I tried to update trove quota with limit -1, as I did in other projects like nova, cinder etc. But it couldn't solve the problem. So I went to the code [1] and found out that -1 in trove quota-show did not means unlimited.

In my opinion, I do think we should support -1 as unlimited resource in trove.

Secondly, I found out that when we update quota, the check for limit could be extended to
accept only -1, not -2 or other negative numbers.

It would be more appropriate to call this bug as a functional supplement

[1]https://github.com/openstack/trove/blob/84af1645ac8b98389cea134f3d4c9e5df78cf61c/trove/quota/quota.py#L148

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/517569

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517569
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=8229572c1d31d2bc686282eab48dd0465f023315
Submitter: Zuul
Branch: master

commit 8229572c1d31d2bc686282eab48dd0465f023315
Author: Fan Zhang <email address hidden>
Date: Fri Nov 3 16:07:26 2017 +0800

    Support -1 as unlimited quota restraint in Trove.

    In other projects like nova and neutron, hard limit -1 often means
    unlimited quota restraint. But Trove dose not support that. This patch
    aims at two things:
    1. Support -1, as unlimited quota restraint in check_quotas()
    2. Add quota check to accept only -1, not -2 or other negative numbers
    when updating quotas.

    Change-Id: I028e6d7814ff240aa3f697e3d6ac8c7bac5bf3fd
    Closes-bug: #1729791
    Signed-off-by: Fan Zhang <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/trove 9.0.0.0b3 development milestone.