Let redis support volume

[jian.song]

I see that we have been in this patch, the trove.conf redis volume_support and device_path set not support volume[1], but in fact, in the follow-up patch, we will volume_support set to True, device_path set to '/ dev / vdb'[2].Now we encountered the problem is that the creation of a single node redis time, no problem, but when the creation of redis cluster, because the troveclient detection[3], no specified volume, and then error.
It seems that we need to change trove.conf in the redis volume_support situation, so that the cluster and single nodes can be normal operation

[1]:https://review.openstack.org/#/c/107117/
[2]:https://review.openstack.org/#/c/262324/1/trove/common/cfg.py
[3]:https://github.com/openstack/python-troveclient/blob/master/troveclient/v1/shell.py#L698

[jian.song (jiansong)]

https://github.com/openstack/openstack-manuals/blob/420e2d2aadb22781914fccbd89d9f9e7178d8013/doc/config-reference/source/tables/trove-db_redis.rst
and in openstack-manuals set volume_support = True and device_path = /dev/vdb

[Amrith Kumar (amrith)]

If all that is required is a change to a conf file, that's something a user can do.

[Launchpad Janitor (janitor)]

[Expired for OpenStack DBaaS (Trove) because there has been no activity for 60 days.]

[jian.song (jiansong)]

Yes,Amrith,I agree with your part of the view. But this problem has affected the normal deployment of redis cluster. Since we have long used the redis cluster and single nodes with volume_support, the changes now seem to help reduce some unnecessary trouble.From now on to unify conf and cfg.py, it seems to be a better choice.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507428
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=5b7930446f5d1ea0bd663aeb9070f35925dced50
Submitter: Zuul
Branch: master

commit 5b7930446f5d1ea0bd663aeb9070f35925dced50
Author: jiansong <email address hidden>
Date: Tue Sep 26 01:34:07 2017 -0700

    Open the volume_support of redis

    In the past, we support volume_support when we support
    redis-cluster[1], but we did not update to conf[2].
    we are making the sample conf files match the
    default configuration in code.

    [1]:https://review.openstack.org/#/c/203702/
    [2]:https://review.openstack.org/#/c/107117/

    Closes-Bug: #1701469
    Change-Id: I428e274fdb85621b21453780e90a8a0ab401ffd9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/530178

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/trove 9.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/530178
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=2ae65178d73d17e4c2d628e911b354233f5c01ed
Submitter: Zuul
Branch: stable/pike

commit 2ae65178d73d17e4c2d628e911b354233f5c01ed
Author: jiansong <email address hidden>
Date: Tue Sep 26 01:34:07 2017 -0700

    Open the volume_support of redis

    In the past, we support volume_support when we support
    redis-cluster[1], but we did not update to conf[2].
    we are making the sample conf files match the
    default configuration in code.

    [1]:https://review.openstack.org/#/c/203702/
    [2]:https://review.openstack.org/#/c/107117/

    Closes-Bug: #1701469
    Change-Id: I428e274fdb85621b21453780e90a8a0ab401ffd9
    (cherry picked from commit 5b7930446f5d1ea0bd663aeb9070f35925dced50)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/trove 8.0.1 release.