Non-lazy loaded configuration options depend on import order

Bug #1694538 reported by Erik Olof Gunnar Andersson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Erik Olof Gunnar Andersson

Bug Description

Configuration options should always be lazy-loaded, this is to prevent changes in import order from interfering with the configuration variable being instantiated properly.

This is currently causing the following variables to always be set to their default values.
> agent_call_low_timeout
> agent_call_high_timeout
> agent_replication_snapshot_timeout
> remote_(nova|cinder|neutron)_client config

This is essentially a follow up to bug 1671655 that caused PROXY_AUTH_URL previously found in trove/common/remote.py to always be set to the default value: "http://0.0.0.0:5000/v2.0".
> PROXY_AUTH_URL = CONF.trove_auth_url

Changed in trove:
assignee: nobody → Erik Olof Gunnar Andersson (eandersson)
status: New → In Progress
description: updated
Changed in trove:
importance: Undecided → Low
Changed in trove:
importance: Low → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/466923
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=fcf75dfd60f3d717f967a07f18ff186205c374e9
Submitter: Zuul
Branch: master

commit fcf75dfd60f3d717f967a07f18ff186205c374e9
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Mon May 22 15:05:34 2017 -0700

    Lazy load all configuration options

    This is a follow up to Change #444040.

    Configuration options should always be lazy loaded,
    this is to prevent changes in import order from
    interfering with the configuration variable being
    instantiated properly.

    Change-Id: I3040108128ba56746ed4d5d688b8b8d33da753fc
    Closes-Bug: #1694538

Changed in trove:
status: In Progress → Fix Released
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/trove 9.0.0.0b3

This issue was fixed in the openstack/trove 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.