Applying module again writes new instance_modules record

[Peter Stachowski]

The module feature of Trove has been designed to be idempotent, in that a module should be able to be applied more than once will no ill side effects. Unfortunately a new instance_modules record is written for each apply, potentially leaving records behind on module-remove that make it impossible to delete the module.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/394765

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/394765
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=2f3703bb34810eb8fd8b1f8cac45ee425168ff13
Submitter: Jenkins
Branch: master

commit 2f3703bb34810eb8fd8b1f8cac45ee425168ff13
Author: Peter Stachowski <email address hidden>
Date: Tue Nov 8 05:26:58 2016 +0000

    Fix module apply

    The module feature of Trove has been designed to be idempotent, in
    that a module should be able to be applied more than once with no ill
    side effects. Unfortunately a new instance_modules record is written
    for each apply, potentially leaving records behind on module-remove
    that make it impossible to delete the module.

    This has been fixed and code put in place on module-apply and
    module-delete to remove any extraneous records.

    Depends-On: Ia4fc545a10c7c16532aefd73818dd7d90c9c271b
    Change-Id: I09b301c1fb8311f9c5bee07d0af398071da3dd24
    Closes-Bug: #1640010

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/trove 7.0.0.0b2 development milestone.