Configure taskmanager_manager default value as taskmanager_manager in cfg.py

[Shaik Apsar]

Add new default option for taskmanager_manager.

By doing this operators / users need not to be configure taskmanager_manager value explicitly.

[DEFAULT]
taskmanager_manager = trove.taskmanager.manager.Manager

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/386632

[Amrith Kumar (amrith)]

Why is this a bug?

[Shaik Apsar (sa709c)]

Amrith,

We have to explicitly specify the Manager implementation for the taskmanager in taskmanager conf file. if that parameter is omitted then trove-taskmaster will fail to start with an error "AttributeError: 'NoneType' object has no attribute 'rpartition'".

By adding the taskmanager_manager option to cfg.py with default implementation, We don't need to care about the taskmanager_manager manual addition to the conf file.

Please refer the "Finalize installation" section in [1]. Due to a bug in the Ubuntu packages, all the trove services using /etc/trove/trove.conf file as the config file. We have to add taskmanager_manager conf manually in trove.conf so that task-taskmanager service will start.

If we have any other implementation for taskmanager Manager in future, we can override the taskmanager_manager value in respective conf file.

[1] http://docs.openstack.org/mitaka/install-guide-ubuntu/trove-install.html

[Amrith Kumar (amrith)]

So that sounds like a bug in the packaging!

[Shaik Apsar (sa709c)]

Amrith,

Even it was bug in packing, I want to make the sure to add taskmanager_manager with default value in cfg.py file, so that we don't need to add taskmanager_manager manually.

It's also useful to set taskmanager_manager with os_service_default in puppet-trove module if we add the default value in cfg.py file.

https://review.openstack.org/#/c/386587/

[OpenStack Infra (hudson-openstack)]

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/386632
Reason: "abandoned for inactivity, currently over 2 weeks old, and not currently mergeable"