Incorrect variable argument type on configuration detach

Bug #1599656 reported by Petr Malik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Petr Malik

Bug Description

Change I65e8a8d5dc251a8b00529cdfb1a6ada3d5720f68 has switched from MySQL-python to PyMySQL.
This change surfaced an issue in the current implementation of configuration groups.

Detaching a configuration group may now lead to "Incorrect argument type to variable 'key_buffer_size'".

The restored default values read from the configuration template as strings
get quoted by Trove. MySQL however does not like numeric values quoted.

This issue is currently reproduced by MySQL configuration scenario tests.

Petr Malik (pmalik)
Changed in trove:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/338662

Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/343119

Changed in trove:
assignee: Petr Malik (pmalik) → Peter Stachowski (peterstac)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by Peter Stachowski (<email address hidden>) on branch: master
Review: https://review.openstack.org/343119
Reason: I'll let Petr fix up the original

Changed in trove:
assignee: Peter Stachowski (peterstac) → Petr Malik (pmalik)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/338662
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=df509b7252b28b2ab4eff9f4d496e71e71b7f879
Submitter: Jenkins
Branch: master

commit df509b7252b28b2ab4eff9f4d496e71e71b7f879
Author: Petr Malik <email address hidden>
Date: Wed Jul 6 20:40:43 2016 -0400

    Preserve data type when parsing MySQL configs

    The data type information was lost in conversions.

    IniCodec should deserialize Python objects (like other codecs).
    guestagent_utils.to_bytes should return byte values as ints.

    * The IniCodec is also used by Cassandra.
      Tested with both MySQL and Cassandra scenario tests.

    Change-Id: Ibb703b3db6814fc0c9ea4c6d96399f6c881cea03
    Closes-Bug: 1599656

Changed in trove:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/trove 6.0.0.0b3

This issue was fixed in the openstack/trove 6.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/trove 6.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.