Change in innobackupex breaking the gate

[Peter Stachowski]

A recent release of Percona XtraBackup (see https://www.percona.com/doc/percona-xtrabackup/2.3/release-notes/2.3/2.3.4.html ) has tightened up the validation of options passed to the innobackupex script (see https://bugs.launchpad.net/percona-xtrabackup/+bug/1533542 ).

The options supplied to innobackupex in the MySQL restore strategy are slightly incorrect. This was ignored previously but now causes the backups to fail.

The options need to be specified correctly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/294290

[Peter Stachowski (peterstac)]

This issue likely affects previous versions of Trove (namely stable/liberty and stable/kilo). I'm currently running tests to verify this and if so will submit backports of this fix to both branches.

[Peter Stachowski (peterstac)]

On further reflection, for stable/liberty and stable/kilo we peg the version of percona-xtrabackup to 2.2. This should continue to work with the existing code (since that's what it's been tested with).

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/294290
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=5f0d88c163a3117ec259a33230ede003b1c3e1e2
Submitter: Jenkins
Branch: master

commit 5f0d88c163a3117ec259a33230ede003b1c3e1e2
Author: Peter Stachowski <email address hidden>
Date: Thu Mar 17 21:17:57 2016 +0000

    Fix incorrect innobackupex args (fixed gate)

    A recent release of Percona XtraBackup has tightened up the
    validation of options passed to the innobackupex script.

    See:
    https://www.percona.com/doc/percona-xtrabackup/2.3/release-notes/2.3/2.3.4.html
    https://bugs.launchpad.net/percona-xtrabackup/+bug/1533542

    The options supplied to innobackupex in the MySQL restore strategy
    are slightly incorrect - this was ignored previously but now causes
    the backups to fail.

    The options are now specified correctly.

    Change-Id: Ic4671998f0c4467f17caa60cbb3106f49c505a2e
    Closes-Bug: #1558794

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/trove 5.0.0.0rc1 release candidate.