the pinning of horizon using a path in trove-dashboard and manila-ui test-requirements.txt conflicts with other projects

Bug #1551908 reported by Amrith Kumar
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
New
Undecided
Duk Loi

Bug Description

Currently, we have the following in test-requirements.txt for trove-dashboard

-e git://github.com/openstack/horizon.git#egg=horizon

If other projects cause horizon to be installed (such as because their plugins are enabled), devstack will crap out.

I find this when running trove-integration's redstack install when I enable manila and since it's plugin also chooses to get horizon. and it's test-requirements.txt is similarly:

-e git://github.com/openstack/horizon.git#egg=horizon

Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

manila-ui does not install test-requirements.txt deps in devstack after following fix: https://github.com/openstack/manila/commit/d495ea535ef921d1257811fdd7b482b73edb8a07

So, I recommend to do the same for trove. UI "test" deps shoudl not be installed by Devstack in host system.

affects: manila → manila-ui
Changed in manila-ui:
status: New → Invalid
Amrith Kumar (amrith)
no longer affects: manila-ui
Revision history for this message
Duk Loi (duktesora) wrote :

So it appears that sahara-dashboard solves this issue by not having the git clone of horizon in the test-requirements and calling the equivalent git clone in a separate script that is invoked by a reference in tox.ini.

The install of horizon script in sahara-dashboard/tools/pip_install.sh has a great explanation of the solution. We should "borrow" the solution from Sahara which derived it from Neutron.

Duk Loi (duktesora)
Changed in trove:
assignee: nobody → Duk Loi (duktesora)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.