trove test-requirements.txt pins python-troveclient with a filename causing failures

[Amrith Kumar]

redstack install fails with this ..

Installing collected packages: trove
  Running setup.py develop for trove
Successfully installed trove-4.0.1.dev199
Installing test-requirements for /opt/stack/trove/test-requirements.txt
Ignoring dnspython3: markers "python_version=='3.4'" don't match your environment
Ignoring os-win: markers "python_version=='3.4'" don't match your environment
Ignoring python-ironic-inspector-client: markers "python_version=='3.4'" don't match your environment
Ignoring requestsexceptions: markers "python_version=='3.4'" don't match your environment
Could not satisfy constraints for 'python-troveclient': installation from path or url cannot be constrained to a version

It turns out that the reason for this failure is ...

amrith@amrith-work:/opt/stack/trove$ sudo -H /usr/local/bin/pip2.7 install -c /opt/stack/requirements/upper-constraints.txt -r /opt/stack/trove/test-requirements.txt
Ignoring dnspython3: markers "python_version=='3.4'" don't match your environment
Ignoring os-win: markers "python_version=='3.4'" don't match your environment
Ignoring python-ironic-inspector-client: markers "python_version=='3.4'" don't match your environment
Ignoring requestsexceptions: markers "python_version=='3.4'" don't match your environment
Could not satisfy constraints for 'python-troveclient': installation from path or url cannot be constrained to a version

devstack now munges upper-constraints.txt and points to a file and therefore the entry in trove's test-requirements.txt is causing a problem.

[Amrith Kumar (amrith)]

fix coming shortly ...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/274345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/274345
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=cef9197dd6f709e55ba7d831e40d7dccabd2d5fd
Submitter: Jenkins
Branch: master

commit cef9197dd6f709e55ba7d831e40d7dccabd2d5fd
Author: Amrith Kumar <email address hidden>
Date: Sat Jan 30 06:48:48 2016 -0500

    Fix issue of mismatched test-requirements.txt file

    When you run devstack, the trove plugin installs python-troveclient by
    forcing upper-constraints.txt in requirements to be changed as below.

    -python-troveclient===2.0.0
    +-e file:///opt/stack/python-troveclient#egg=python-troveclient

    As a result, pinning test-requirements.txt to use a file for
    python-troveclient to come from tarballs.openstack.org causes a
    failure.

    The error you will see is "Could not satisfy constraints for
    'python-troveclient': installation from path or url cannot be
    constrained to a version".

    This change modifies test-requirements.txt and matches
    global-requirements.txt, and devstack makes the change (above) to
    upper-constraints.txt which accomplishes the same thing.

    Change-Id: I3bb748a575d67f9f419f51837555d18ed5d7ca32
    Closes-Bug: 1539818

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/trove 5.0.0.0b3 development milestone.