Inconsistency in package format in datastore definition (OS-dependent)

[Luigi Toscano]

The manual installation procedure requires the "package" to be specified:

http://docs.openstack.org/developer/trove/dev/manual_install.html

$ trove-manage datastore_version_update ${DATASTORE_TYPE} ${DATASTORE_VERSION} ${DATASTORE_TYPE} ${IMAGEID} ${PACKAGES} 1

The format of PACKAGES in the documentation appears both as package-version and package=version in the same page.

Checking the code, namely trove/guestagent/pkg.py, it seems that this is OS-dependent. The two available classes (RedhatPackagerMixin and DebianPackagerMixin) require two different format (see pkg_is_installed() and pkg_version()). Debian mixin requires package=version, RedHat* mixin requires package-version.

The existing unit tests (trove/tests/unittests/guestagent/test_pkg.py) only check the Debian case.

The above should be an implementation detail and the same format should be used in both cases.