Fix potentially broken test test_backup_incremental_metadata

[Amrith Kumar]

It isn't really clear what this test (test_backup_incremental_metadata) is aiming to do and the problem with the test is masked by the fact that logging isn't enabled properly. Therefore, one doesn't know that the test actually fails silently with this ...

ERROR:trove.guestagent.backup.backupagent:Error saving backup: 123.
Traceback (most recent call last):
  File "trove/guestagent/backup/backupagent.py", line 106, in stream_backup_to_storage
    meta['datastore'] = backup_info['datastore']
KeyError: 'datastore'

This is related to 1491075

[Istimsak (saqman2060)]

Www
On Sep 1, 2015 3:10 PM, "Amrith" <email address hidden> wrote:
>
> Public bug reported:
>
> It isn't really clear what this test (test_backup_incremental_metadata)
> is aiming to do and the problem with the test is masked by the fact that
> logging isn't enabled properly. Therefore, one doesn't know that the
> test actually fails silently with this ...
>
> ERROR:trove.guestagent.backup.backupagent:Error saving backup: 123.
> Traceback (most recent call last):
> File "trove/guestagent/backup/backupagent.py", line 106, in
stream_backup_to_storage
> meta['datastore'] = backup_info['datastore']
> KeyError: 'datastore'
>
> This is related to 1491075
>
> ** Affects: trove
> Importance: Undecided
> Assignee: Amrith (amrith)
> Status: New
>
> --
> You received this bug notification because you are subscribed to
> OpenStack.
> Matching subscriptions: istimsak
> https://bugs.launchpad.net/bugs/1491093
>
> Title:
> Fix potentially broken test test_backup_incremental_metadata
>
> Status in Trove:
> New
>
> Bug description:
> It isn't really clear what this test
> (test_backup_incremental_metadata) is aiming to do and the problem
> with the test is masked by the fact that logging isn't enabled
> properly. Therefore, one doesn't know that the test actually fails
> silently with this ...
>
> ERROR:trove.guestagent.backup.backupagent:Error saving backup: 123.
> Traceback (most recent call last):
> File "trove/guestagent/backup/backupagent.py", line 106, in
stream_backup_to_storage
> meta['datastore'] = backup_info['datastore']
> KeyError: 'datastore'
>
> This is related to 1491075
>
Datastore is referred to by two tags. What is datastore?
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/trove/+bug/1491093/+subscriptions

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219544

[Nikhil Manchanda (slicknik)]

This is related to a unit test and is not a blocker for Liberty-RC1.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/219544
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=34ce70e299f57018b370ea0b8aa457f737f470b7
Submitter: Jenkins
Branch: master

commit 34ce70e299f57018b370ea0b8aa457f737f470b7
Author: Amrith Kumar <email address hidden>
Date: Sat Oct 17 18:29:57 2015 -0400

    Correct errors resulting in "No handlers ..." error message

    This is a checkin for the issue of having errors that read "No
    handlers could be found for logger X.Y.Z" when running tests. While
    being annoying, it is also a serious issue in that some times, the
    lack of logging masks errors in the tests. One such example is fixed
    in this chkin (see bug 1491093).

    Change-Id: I4066d226aefbd23248e88692db109d31f5c150e9
    Partial-Bug: #1491075
    Closes-Bug: #1491093

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/trove 5.0.0.0b1 development milestone.