Use more appropriate exceptions for validation

Bug #1482279 reported by Petr Malik on 2015-08-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Low
Craig Vyvial
Juno
Undecided
Unassigned

Bug Description

Use more appropriate exceptions for validation

The client currently throws generic CommandError or even just Exception
types on validation errors. It should use existing ValidationErrors
instead.

Fix proposed to branch: master
Review: https://review.openstack.org/218701

Changed in trove:
status: New → In Progress
Changed in trove:
assignee: Petr Malik (pmalik) → Craig Vyvial (cp16net)

Reviewed: https://review.openstack.org/218701
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=f8f318352729d38a6e70e63a47b919dc9aad95c2
Submitter: Jenkins
Branch: master

commit f8f318352729d38a6e70e63a47b919dc9aad95c2
Author: Petr Malik <email address hidden>
Date: Sun Aug 30 22:02:12 2015 -0400

    Expect ValidationError on an empty user update

    Applying an empty change on user attributes should raise a
    ValidationError.

    This is a requirement for:
    https://review.openstack.org/#/c/210004/

    Depends-On: I5ab58fd64f4745a2e558392bff649b05401ed57a
    Change-Id: I778bb408ba1f3b58037b77e56e33ee0020156c86
    Closes-Bug: 1482279

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
milestone: none → liberty-rc1
importance: Undecided → Low

Reviewed: https://review.openstack.org/221539
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=92efd0b2ef2964ebe401e74222004177e5aa921d
Submitter: Jenkins
Branch: stable/juno

commit 92efd0b2ef2964ebe401e74222004177e5aa921d
Author: Petr Malik <email address hidden>
Date: Sun Aug 30 22:02:12 2015 -0400

    Expect ValidationError on an empty user update

    Applying an empty change on user attributes should raise a
    ValidationError.

    This is needed for Trove int-tests to run on the stable/juno
    branch.

    Depends-On: I5ab58fd64f4745a2e558392bff649b05401ed57a
    Cherry-picked-from: f8f318352729d38a6e70e63a47b919dc9aad95c2
    Closes-Bug: 1482279
    Change-Id: I778bb408ba1f3b58037b77e56e33ee0020156c86

tags: added: in-stable-juno
Thierry Carrez (ttx) on 2015-09-24
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2015-10-15
Changed in trove:
milestone: liberty-rc1 → 4.0.0

This issue was fixed in the openstack/python-troveclient 1.3.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers