Cluster instances could report 'ready' when they are not

Bug #1478603 reported by Matthew Van Dijk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Matthew Van Dijk

Bug Description

The check used by all cluster strategies is wrong. It allows for both RUNNING and BUILD_PENDING. All cluster strategies use BUILD_PENDING to indicate that the instances are cluster-prepare ready. RUNNING is bad as it can be reported before the instance's prepare even starts, causing the cluster-prepare to start too early and fail.

Changed in trove:
assignee: nobody → Matthew Van Dijk (mvandijk)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/206115

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/206115
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=76c81c4625648608d7873ede630e3f727b8d2fd6
Submitter: Jenkins
Branch: master

commit 76c81c4625648608d7873ede630e3f727b8d2fd6
Author: Matt Van Dijk <email address hidden>
Date: Mon Jul 27 11:29:55 2015 -0400

    Cluster instances could falsely report 'ready'

    The check used by all cluster strategies is wrong. It allows for both
    RUNNING and BUILD_PENDING. All cluster strategies use BUILD_PENDING to
    indicate that the instances are cluster-prepare ready. RUNNING is bad as
    it can be reported before the instance's prepare even starts, causing
    the cluster-prepare to start too early and fail.

    The fix is to remove RUNNING from the list of cluster-ready states. It
    has been verified that all datastores set instances to BUILD_PENDING
    when used for clusters.

    Change-Id: I048e2b76fda59a25928c6c6d3751235df12d7369
    Closes-bug: #1478603

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
milestone: none → liberty-3
importance: Undecided → High
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: liberty-3 → 4.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.