test appears to verify wrong value in assert

Bug #1424741 reported by Amrith Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Amrith Kumar

Bug Description

It appears that the test at

https://github.com/openstack/trove/blob/master/trove/tests/unittests/guestagent/test_agent_heartbeats_models.py#L206-L209

incorrectly checks for haertbeat_found when it should be checking for updated_heartbeat.

Amrith Kumar (amrith)
Changed in trove:
milestone: none → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/158374

Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/158374
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=b9820ab41a9f22e4ec80ab7dcd81f054ca87e20f
Submitter: Jenkins
Branch: master

commit b9820ab41a9f22e4ec80ab7dcd81f054ca87e20f
Author: Amrith Kumar <email address hidden>
Date: Mon Feb 23 12:45:31 2015 -0500

    Correct a test and order of parameters to assertEqual

    In debugging a failing test (test_update_heartbeat) I observed that
    the test was asserting incorrect values and also that the order of
    parameters to assertEqual were inverted. It appears that the order of
    parameters to assertEqual is a more widespread problem.

    The correct order makes the assertion message more useful.

    Change-Id: Ide9f60f8338398ad8e61ad81f4a30058e415f8e9
    Closes-Bug: #1424741
    Partial-Bug: #1277104

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.