PostgreSQL manager should raise exceptions for all unsupported features

Bug #1414813 reported by Nirav Shah
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Triaged
Low
Nirav Shah

Bug Description

Presently, postgresql manager doesn't have many definitions that could be called by the task manager.
We need to implement these definitions, and just raise an exception for all unsupported features.

As an example, it is possible for the task manager to call get_replication_snapshot. But since this definition doesn't exist in postgresql's manager.py, python will fail with an unhelpful message along the lines of "Exception during message handling" and "No such RPC function 'get_replication_snapshot'".

It would be much more helpful to the user, if we fail with raising a DatastoreOperationNotSupported exception.

Nirav Shah (nirav)
Changed in trove:
assignee: nobody → Nirav Shah (nirav)
Revision history for this message
Denis M. (dmakogon) wrote :

I agree with this, but how PostgreSQL driver can raise exception against replication snapshot if it doesn't support building master-slave replication in Trove? Take a look at replication strategy. And take a look at https://github.com/openstack/trove/blob/master/trove/instance/models.py#L706

Changed in trove:
status: New → Triaged
importance: Undecided → Low
milestone: none → kilo-3
Changed in trove:
milestone: kilo-3 → kilo-rc1
Changed in trove:
milestone: kilo-rc1 → liberty-1
Changed in trove:
milestone: liberty-1 → liberty-2
Changed in trove:
milestone: liberty-2 → liberty-3
Changed in trove:
milestone: liberty-3 → next
Revision history for this message
Amrith Kumar (amrith) wrote :

Nirav, any updates on this?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.