Trove doesn't inject trove-guestagent.conf if use_nova_server_volume enabled

[Denis M.]

Trove doesn't inject trove-guestagent.conf if use_nova_server_volume enabled

https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L437-L482

Same for user data.

Same for config drive.

This is critical bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/136062

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136062
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=3e618f316da4903571c4e4af8243fb70b372f78d
Submitter: Jenkins
Branch: master

commit 3e618f316da4903571c4e4af8243fb70b372f78d
Author: Denis Makogon <email address hidden>
Date: Thu Nov 20 19:08:55 2014 +0200

    Fix broken instance provisioning with disabled volume support

    Reasons:
     - in certain deployments that has disabled volume support, different volume types
       (iSCSI instead of virtio) Trove doesn't inject trove-guestagent.conf, userdata,
       disables "config-drive"-based injection

    Changes:
     - refactoring code to use one common function to prepare files and usedata
     - adding to Nova call:
       - config_drive parameter;
       - userdata

    Change-Id: Icfa7d26a29c313e0d3f056dda389787ca3638506
    Closes-Bug: #1394654