Do not use obsolete modules from oslo-incubator

Bug #1380789 reported by Nikhil Manchanda
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Amrith Kumar

Bug Description

There are quite a few modules that are in use in Trove today that were in the past taken from oslo-incubator, but which have now been graduated to their own libraries -- obsoleting them from oslo-incubator.

Trove still uses a few of these modules. We need to go through them and ensure that we are using the current modules from the oslo libs, and not the obsolete code from the oslo-incubator modules.

The specific modules in question are:
openstack/trove: exception
openstack/trove: excutils
openstack/trove: gettextutils
openstack/trove: importutils
openstack/trove: iniparser
openstack/trove: jsonutils
openstack/trove: network_utils
openstack/trove: notifier
openstack/trove: pastedeploy
openstack/trove: rpc
openstack/trove: strutils
openstack/trove: testutils
openstack/trove: timeutils
openstack/trove: utils
openstack/trove: wsgi

Revision history for this message
Denis M. (dmakogon) wrote :

"network_utils" module is a dependency of kombu implementation of RPC backend.
see https://github.com/openstack/trove/search?utf8=%E2%9C%93&q=network_utils&type=Code

Revision history for this message
Denis M. (dmakogon) wrote :

"testutils" module can be dropped off because it's not used anywhere
see https://github.com/openstack/trove/search?utf8=%E2%9C%93&q=testutils&type=Code

Revision history for this message
Amrith Kumar (amrith) wrote :

I'm working in a proximate area anyway so I'm assigning this to myself.

Changed in trove:
assignee: nobody → Amrith (amrith)
Revision history for this message
Denis M. (dmakogon) wrote :

Amrith, we might split this task, same as we did with logging.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129204

Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129205

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129206

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129207

Revision history for this message
Amrith Kumar (amrith) wrote :

An etherpad tracking this activity has been created at

https://etherpad.openstack.org/p/trove-kilo-do-not-use-obsolete-oslo-modules

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/129204

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/129205

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/129206

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/129207

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129292

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129293

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129295

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/129293

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129378

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129654

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129663

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129664

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129668

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/129714

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/133051

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/133068

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/129378
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=0311146ee7b57116b4d3eb72b8e82be3998e9fad
Submitter: Jenkins
Branch: master

commit 0311146ee7b57116b4d3eb72b8e82be3998e9fad
Author: Amrith Kumar <email address hidden>
Date: Wed Nov 5 04:53:44 2014 -0500

    Obsolete oslo-incubator modules - importutils

    This change is part of a multi-part change set to handle obsolete and
    graduated oslo modules. This change addresses import utils that is now
    part of oslo.utils.

    The file importutils is not being deleted because of dependencies
    within oslo-incubator

    Partial-Bug: #1380789
    Change-Id: I8bd0275c2fb33fc3ebcea578a2746bfe755ce1e8
    blueprint: retire-unused-oslo-incubator-modules

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/129295
Reason: Will update https://review.openstack.org/#/c/129292 to contain these changes.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/129654
Reason: Abandoned in favor of https://review.openstack.org/#/c/129292

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/129663
Reason: Abandoned in favor of https://review.openstack.org/#/c/129292

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/129664
Reason: Abandoned in favor of https://review.openstack.org/#/c/129292

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/129292
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=b480b8769b9bada07c3050fd42fd7534c01e9f6e
Submitter: Jenkins
Branch: master

commit b480b8769b9bada07c3050fd42fd7534c01e9f6e
Author: Amrith Kumar <email address hidden>
Date: Fri Oct 17 10:31:01 2014 -0400

    Obsolete oslo-incubator modules - unused modules

    This change is part of a multi-part change set to handle obsolete and
    graduated oslo modules.

    This commit handles obsolete oslo-incubator modules that are not used
    in Trove but are referenced in openstack-common.conf

    The change here is to remove them from openstack-common.conf and
    delete them from trove/openstack/common.

    While excutils, network_utils and strutils are deleted from
    openstack-common.conf the files are retained because of dependencies
    within oslo-incubator.

    Change-Id: I77535f6798f202f51f04b94ee9271b139b5c6b78
    Blueprint: retire-unused-oslo-incubator-modules
    Partial-Bug: #1380789

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141081

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/141090

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/129294
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=0fec4bccdcaa0424351458542f39d5b8400432f9
Submitter: Jenkins
Branch: master

commit 0fec4bccdcaa0424351458542f39d5b8400432f9
Author: Amrith Kumar <email address hidden>
Date: Wed Dec 10 13:25:56 2014 -0500

    Obsolete oslo-incubator modules - timeutils

    This change is part of a multi-part change set to handle obsolete and
    graduated oslo modules.

    This commit handles the timeutils module.

    The change here is to remove it from openstack-common.conf and point
    all modules who used to use that at oslo.utils. This also involves a
    change to requirements.txt.

    I have rebased this change and made it dependent on the change in
    https://review.openstack.org/#/c/129292/

    Change-Id: I31176c0a78e734bfad3b40b2ec634ea8f362d81b
    Partial-Bug: #1380789
    blueprint: retire-unused-oslo-incubator-modules

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/129668
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=a52f7cf5866d6850d357fabffb59958c8d56d0c5
Submitter: Jenkins
Branch: master

commit a52f7cf5866d6850d357fabffb59958c8d56d0c5
Author: Amrith Kumar <email address hidden>
Date: Wed Dec 10 13:53:33 2014 -0500

    Obsolete oslo-incubator modules - jsonutils (now oslo.serialization)

    This change is part of a multi-part change set to handle obsolete and
    graduated oslo modules. This commit handles the jsonutils module which
    is now oslo.serialization.jsonutils. The change here is to remove it
    from openstack-common.conf and point all people who used to use that
    at oslo.serialization. requirements.txt has been updated to point to
    this dependency.

    The file jsonutils.py is not being deleted because of dependencies in
    oslo-incubator.

    Change has been rebased on https://review.openstack.org/#/c/129294/

    Change-Id: I2a7d4c41ce77d6375fa08033514baa815a087016
    Partial-Bug: #1380789
    blueprint: retire-unused-oslo-incubator-modules

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/129714
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=3e56c2177b30527475b04d0c0c099a55854942dc
Submitter: Jenkins
Branch: master

commit 3e56c2177b30527475b04d0c0c099a55854942dc
Author: Amrith Kumar <email address hidden>
Date: Wed Dec 10 14:05:47 2014 -0500

    Obsolete oslo-incubator modules - gettextutils (now oslo.i18n)

    This change is part of a multi-part change set to handle obsolete and
    graduated oslo modules. This commit handles the gettextutils module
    which is now oslo.i18n. The change here is to remove it from
    openstack-common.conf and point all people who used to use that at
    oslo.i18n. requirements.txt has been updated to point to this
    dependency.

    We aren't deleting gettextutils.py from openstack/common because it is
    used by other oslo-incubator modules.

    This change has been rebased on https://review.openstack.org/#/c/129668/

    Change-Id: I39fd288fb29a8317f896812a2f64bcd69a6b8e21
    Partial-Bug: #1380789
    blueprint: retire-unused-oslo-incubator-modules

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/133051
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=fb83a84e62489e822ae44bbef74faa467e443632
Submitter: Jenkins
Branch: master

commit fb83a84e62489e822ae44bbef74faa467e443632
Author: Amrith Kumar <email address hidden>
Date: Wed Dec 10 15:04:04 2014 -0500

    Obsolete oslo-incubator modules - exception

    This change is part of a multi-part change set to handle obsolete and
    graduated oslo modules. This change relates to the exception module
    that is now obsolete. The change here is to delete the file from
    openstack-common.conf and handle the change as it ripples into the
    modules that used to include exception.

    The change is modeled on the change that was implemented in
    oslo-incubator when this module was deprecated. See review
    https://review.openstack.org/#/c/39314

    wsgi.py will be deprecated in another change so the only change being
    made here is (effectively) to extensions.py

    We can't delete the file in openstack/common because there is still a
    dependency within oslo-incubator.

    This change has been rebased on https://review.openstack.org/#/c/129714/

    Blueprint: retire-unused-trove-modules
    Partial-Bug: #1380789
    Change-Id: I55e81693866cb15b3b06ee2ad1700f144023cc60

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/133068
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=f86a0e6cc283cd786d244b394892ced8bc32eeaa
Submitter: Jenkins
Branch: master

commit f86a0e6cc283cd786d244b394892ced8bc32eeaa
Author: Amrith Kumar <email address hidden>
Date: Wed Dec 10 15:17:46 2014 -0500

    Obsolete oslo-incubator modules - wsgi

    This change is part of a multi-part change set to handle obsolete and
    graduated oslo modules. This commit handles the wsgi module. The way
    in which other projects appear to have handled this situation is to
    copy the wsgi module into the project. See, for example,
    https://review.openstack.org/#/c/129260/

    I've done the same thing, and since we already have a wsgi module in
    trove/common, I've called the newly imported module base_wsgi.py and
    renamed the imports accordingly.

    In the fullness of time, we could consider merging wsgi.py and
    base_wsgi.py

    However since there are internal dependencies between
    middleware/context.py and wsgi.py (within oslo-incubator) I can't
    delete or modify those files.

    This change has been rebased on
    https://review.openstack.org/#/c/133051/

    Change-Id: I029b7f569342f768ebcdfc2fb7224f4f7f00d48c
    Partial-Bug: #1380789
    blueprint: retire-unused-trove-modules

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/141081
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=8475ba585e5515ebf6eec84f65ae350fa1de6af1
Submitter: Jenkins
Branch: master

commit 8475ba585e5515ebf6eec84f65ae350fa1de6af1
Author: Amrith Kumar <email address hidden>
Date: Thu Dec 11 10:50:34 2014 -0500

    Obsolete oslo-incubator modules - processutils

    This change is part of a multi-part change set to handle obsolete and
    graduated oslo modules. This commit handles the processutils module
    which is now oslo.concurrency (oslo_concurrency). The change here is
    to remove it from openstack-common.conf and add oslo.concurrency to
    requirements.txt. Since nothing in oslo-incubator depends on
    processutils, the module is also deleted from the oslo-incubator
    imports.

    This change is based on top of https://review.openstack.org/#/c/133068

    Change-Id: I5cba2f487b51c877d036acf552df3b64f7c85764
    Partial-Bug: #1380789

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/141090
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=25cf51f43737f03efb9972e1b8f04a2e74e14f2a
Submitter: Jenkins
Branch: master

commit 25cf51f43737f03efb9972e1b8f04a2e74e14f2a
Author: Amrith Kumar <email address hidden>
Date: Thu Dec 11 11:25:54 2014 -0500

    Eliminate redundant modules from oslo-incubator

    This change is part of a multi-part change set to handle obsolete and
    graduated oslo modules. This commit cleans up openstack-common.conf
    which has unnecessary entries for middleware and fileutils that are
    not required in trove.

    Also, trove acquired a trove/openstack/common/utils.py which had two
    routines that were long ago moved into strutils (now oslo.utils). The
    sole remaining reference to that source file has been updated to
    reflect this.

    This change is based on https://review.openstack.org/#/c/141081/

    Change-Id: I279161ac7b321f306df180a2df20f64e869866b0
    Partial-Bug: #1380789

Changed in trove:
importance: Undecided → Medium
milestone: none → kilo-2
Changed in trove:
milestone: kilo-2 → kilo-3
Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers