Configuration Group DB Load Fails If Datastore Version is Inactive

[Auston McReynolds]

trove-manage db_load_datastore_config_parameters will fail if the datastore_version on which it's being run is marked as inactive (aka active is set to 0).

this is not correct, because it's completely reasonable to want to update/refresh a datastore_version's configuration-group's parameters even if it's inactive.

examples:
- you're rolling out a new datastore_version, so you have it marked as active=0 until your launch date.
- you've rolled out a new datastore_version, and you want to deactivate the old datastore_version. instances built prior to the deactivate are still on the old_version, and can still utilize their configuration-groups, hence the parameters should be update'able by the admin/cloud provider.

how to reproduce:

sudo /usr/local/bin/trove-manage --config-file=/etc/trove/trove.conf datastore_version_update mysql 5.5 mysql 1-2-3-4 "mysql-server-5.5" 0

sudo /usr/local/bin/trove-manage db_load_datastore_config_parameters mysql 5.5 /opt/stack/trove/trove/templates/mysql/validation-rules.json

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/129145

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/129145
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=7d26dfe906f3509c48fa7a14048e742c6d7268cb
Submitter: Jenkins
Branch: master

commit 7d26dfe906f3509c48fa7a14048e742c6d7268cb
Author: amcrn <email address hidden>
Date: Thu Oct 16 23:14:20 2014 -0700

    Config Group Load Fails If DS Version Inactive

    trove-manage db_load_datastore_config_parameters will fail if
    the datastore_version on which it's being run is marked as
    inactive (aka active is set to 0).

    this is not correct, because it's completely reasonable to want
    to update/refresh a datastore_version's configuration-group's
    parameters even if it's inactive.

    examples:
    - you're working on rolling out a new datastore_version, so
      you have it marked as active=0 until the go-live date.
    - you've rolled out a new datastore_version and want to
      mark the old version as inactive. instances built prior
      to the inactivation are still on the old version, and
      can still utilize their still-assigned configuration-groups,
      hence the parameters should be updateable by the
      administrator.

    Change-Id: I7682fe240c5737438b084d813cf7ce80b4ecca9b
    Closes-Bug: #1379563