Guest agent still depends on trove models

Bug #1375311 reported by Robert Myers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Robert Myers

Bug Description

There is still a couple spots where the guest agent is trying to import models used in trove. Namely the backup models and the agent heartbeat. None of the code in the guest actually uses the database models but all the logic gets loaded for the sqlalcemy models and causes the guest binary to bloat on the host by about 20 megs of RSS.

Moving the backup state to a separate module and removing an used function lowers the memory usage by about 15 - 20 Megs.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124777

Changed in trove:
assignee: nobody → Robert Myers (rmyers)
status: New → In Progress
Changed in trove:
importance: Undecided → High
Changed in trove:
milestone: none → juno-rc1
Revision history for this message
Nikhil Manchanda (slicknik) wrote :

Moving to kilo, since this is not blocking Juno RC1 release.

Changed in trove:
milestone: juno-rc1 → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/124777
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=0007a5076aa795fc354b122ae591980c9413f054
Submitter: Jenkins
Branch: master

commit 0007a5076aa795fc354b122ae591980c9413f054
Author: Robert Myers <email address hidden>
Date: Sat Sep 27 19:25:59 2014 -0500

    Removing dependency on trove models in the guest agent

    Reasons:
     - The guest agent is importing backup models and agent
       heartbeat, this triggers the all of the trove database
       setup logic which bloats the guest process on the host.

     - Moving the state to its own module and removing an unused
       function decreases the memory usage by about 15 - 20 megs.

    Closes-Bug: #1375311
    Change-Id: I126c0b89c170b325d85b3f09afca399b4f5de9e8

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.