Activity log for bug #1372895

Date Who What changed Old value New value Message
2014-09-23 11:47:58 Denis M. bug added bug
2014-09-23 11:53:33 Denis M. description Trove should have unit tests isolated from fake-mode int-tests. Due to use of common sqllite backend during tox testing unit tests are not failing because sqlite contains required data, such as: datastore and its versions. This issue cause next bugs: - https://bugs.launchpad.net/trove/+bug/1302784 Steps to fix: 1. Propose method that cleans up backend right after fake-mode int tests are finished. ( the opposite method to util.init_db() ) 2. For those tests that are requiring datastore and versions - use common parent class inherited from testtools.TestCase and new class that will hadle datastore registration. Trove should have unit tests isolated from fake-mode int-tests. Due to use of common sqllite backend during tox testing unit tests are not failing because sqlite contains required data, such as: datastore and its versions. This issue cause next bugs:  [1] https://bugs.launchpad.net/trove/+bug/1302784 Steps to fix: 1. Propose method that cleans up backend right after fake-mode int tests are finished. ( the opposite method to util.init_db() ) 2. For those tests that are requiring datastore and versions - use common parent class inherited from testtools.TestCase and new class that will hadle datastore registration. Clarification: For some reasons (unkonw) int tests attribute was used for unit tests, that why tests at [1] are failing. https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L21
2014-09-23 12:24:59 Denis M. description Trove should have unit tests isolated from fake-mode int-tests. Due to use of common sqllite backend during tox testing unit tests are not failing because sqlite contains required data, such as: datastore and its versions. This issue cause next bugs:  [1] https://bugs.launchpad.net/trove/+bug/1302784 Steps to fix: 1. Propose method that cleans up backend right after fake-mode int tests are finished. ( the opposite method to util.init_db() ) 2. For those tests that are requiring datastore and versions - use common parent class inherited from testtools.TestCase and new class that will hadle datastore registration. Clarification: For some reasons (unkonw) int tests attribute was used for unit tests, that why tests at [1] are failing. https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L21 Trove should have unit tests isolated from fake-mode int-tests. Due to use of common sqllite backend during tox testing unit tests are not failing because sqlite contains required data, such as: datastore and its versions. This issue cause next bugs:  [1] https://bugs.launchpad.net/trove/+bug/1302784 Steps to fix: 1. Propose method that cleans up backend right after fake-mode int tests are finished. ( the opposite method to util.init_db() ) 2. For those tests that are requiring datastore and versions - use common parent class inherited from testtools.TestCase and new class that will hadle datastore registration. Clarification: For some reasons (unkonw) int tests attribute was used for unit tests, that why tests at [1] are failing. https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L21 https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L36
2014-09-25 12:32:08 Denis M. description Trove should have unit tests isolated from fake-mode int-tests. Due to use of common sqllite backend during tox testing unit tests are not failing because sqlite contains required data, such as: datastore and its versions. This issue cause next bugs:  [1] https://bugs.launchpad.net/trove/+bug/1302784 Steps to fix: 1. Propose method that cleans up backend right after fake-mode int tests are finished. ( the opposite method to util.init_db() ) 2. For those tests that are requiring datastore and versions - use common parent class inherited from testtools.TestCase and new class that will hadle datastore registration. Clarification: For some reasons (unkonw) int tests attribute was used for unit tests, that why tests at [1] are failing. https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L21 https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L36 Trove should have unit tests isolated from fake-mode int-tests. Due to use of common sqllite backend during tox testing unit tests are not failing because sqlite contains required data, such as: datastore and its versions. This issue cause next bugs:  [1] https://bugs.launchpad.net/trove/+bug/1302784 [2] https://bugs.launchpad.net/trove/+bug/1372950 Steps to fix: 1. Propose method that cleans up backend right after fake-mode int tests are finished. ( the opposite method to util.init_db() ) 2. For those tests that are requiring datastore and versions - use common parent class inherited from testtools.TestCase and new class that will hadle datastore registration. Clarification: For some reasons (unkonw) int tests attribute was used for unit tests, that why tests at [1] are failing. https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L21 https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L36
2014-09-25 13:43:15 Denis M. description Trove should have unit tests isolated from fake-mode int-tests. Due to use of common sqllite backend during tox testing unit tests are not failing because sqlite contains required data, such as: datastore and its versions. This issue cause next bugs:  [1] https://bugs.launchpad.net/trove/+bug/1302784 [2] https://bugs.launchpad.net/trove/+bug/1372950 Steps to fix: 1. Propose method that cleans up backend right after fake-mode int tests are finished. ( the opposite method to util.init_db() ) 2. For those tests that are requiring datastore and versions - use common parent class inherited from testtools.TestCase and new class that will hadle datastore registration. Clarification: For some reasons (unkonw) int tests attribute was used for unit tests, that why tests at [1] are failing. https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L21 https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L36 Trove should have unit tests isolated from fake-mode int-tests. Due to use of common sqllite backend during tox testing unit tests are not failing because sqlite contains required data, such as: datastore and its versions. This issue cause next bugs:  [1] https://bugs.launchpad.net/trove/+bug/1302784  [2] https://bugs.launchpad.net/trove/+bug/1372950 Steps to fix: 1. Propose method that cleans up backend right after fake-mode int tests are finished. ( the opposite method to util.init_db() ) 2. For those tests that are requiring datastore and versions - use common parent class inherited from testtools.TestCase and new class that will hadle datastore registration. Clarification: For some reasons (unkonw) int tests attribute was used for unit tests, that why tests at [1] are failing. https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L21 https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L36 After further investigation: 17 tests are not isolated and sharing same backend data: trove/tests/unittests/backup - 5 usages trove/tests/unittests/common - 1 usage trove/tests/unittests/conductor - 1 usage trove/tests/unittests/datastore - 1 usage trove/tests/unittests/guestagent - 6 usages (which is wrong completely becuase agent is on its way to be moved from codebase) trove/tests/unittests/instance - 1 usage trove/tests/unittests/mgmt - 1 usage trove/tests/unittests/taskmanager - 1 usage
2014-09-25 14:00:41 Denis M. description Trove should have unit tests isolated from fake-mode int-tests. Due to use of common sqllite backend during tox testing unit tests are not failing because sqlite contains required data, such as: datastore and its versions. This issue cause next bugs:  [1] https://bugs.launchpad.net/trove/+bug/1302784  [2] https://bugs.launchpad.net/trove/+bug/1372950 Steps to fix: 1. Propose method that cleans up backend right after fake-mode int tests are finished. ( the opposite method to util.init_db() ) 2. For those tests that are requiring datastore and versions - use common parent class inherited from testtools.TestCase and new class that will hadle datastore registration. Clarification: For some reasons (unkonw) int tests attribute was used for unit tests, that why tests at [1] are failing. https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L21 https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L36 After further investigation: 17 tests are not isolated and sharing same backend data: trove/tests/unittests/backup - 5 usages trove/tests/unittests/common - 1 usage trove/tests/unittests/conductor - 1 usage trove/tests/unittests/datastore - 1 usage trove/tests/unittests/guestagent - 6 usages (which is wrong completely becuase agent is on its way to be moved from codebase) trove/tests/unittests/instance - 1 usage trove/tests/unittests/mgmt - 1 usage trove/tests/unittests/taskmanager - 1 usage Trove should have unit tests isolated from fake-mode int-tests. Due to use of common sqllite backend during tox testing unit tests are not failing because sqlite contains required data, such as: datastore and its versions. This issue cause next bugs:  [1] https://bugs.launchpad.net/trove/+bug/1302784  [2] https://bugs.launchpad.net/trove/+bug/1372950 Steps to fix: 1. Propose method that cleans up backend right after fake-mode int tests are finished. ( the opposite method to util.init_db() ) 2. For those tests that are requiring datastore and versions - use common parent class inherited from testtools.TestCase and new class that will hadle datastore registration. Clarification: For some reasons (unkonw) int tests attribute was used for unit tests, that why tests at [1] are failing. https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L21 https://github.com/openstack/trove/blob/master/trove/tests/unittests/instance/test_instance_status.py#L36 After further investigation: 17 tests are not isolated and sharing same backend data:    trove/tests/unittests/backup - 5 usages    trove/tests/unittests/common - 1 usage (not needed at all)    trove/tests/unittests/conductor - 1 usage    trove/tests/unittests/datastore - 1 usage    trove/tests/unittests/guestagent - 6 usages (which is wrong completely becuase agent is on its way to be moved from codebase)    trove/tests/unittests/instance - 1 usage    trove/tests/unittests/mgmt - 1 usage    trove/tests/unittests/taskmanager - 1 usage
2014-09-30 13:54:47 OpenStack Infra trove: status Confirmed In Progress
2014-09-30 13:54:47 OpenStack Infra trove: assignee Denis M. (dmakogon)
2014-12-16 09:49:29 Nikhil Manchanda trove: status In Progress Incomplete
2014-12-16 09:49:36 Nikhil Manchanda trove: milestone kilo-1
2016-04-05 11:08:21 Amrith Kumar trove: assignee Denis M. (dmakogon)
2016-04-05 11:08:29 Amrith Kumar trove: status Incomplete Confirmed