Setting replication_strategy to None for MySQL Does Not Work

[Auston McReynolds]

setting replication_strategy to None in trove.conf under [mysql] does not work as intended (it does not throw an Exception as the code suggests it should @ https://github.com/openstack/trove/blob/f53ba944688b7a6a0df7a37529bb8be2da4b29d0/trove/instance/models.py#L698-L701). instead, it marches on and provisions the slave.

why this matters: some deployers (like me) want the ability to wire on or off replication support.

[Auston McReynolds (amcrn)]

doug: let me know if you're still looking into this, if not, i'll take a look; thanks!

[Doug Shelley (0-doug)]

Auston - go ahead and take it - I don't think I will get to it this week.

[Auston McReynolds (amcrn)]

interesting, because it's a StrOpt, if you have:
    replication_strategy = None

it converts it to the string "None", therefore the check "if not replication_support:" doesn't trigger.

the solution is to set it as follows:

    replication_strategy =

which is not obvious. i'd push a change to check for the string "None", but that sets a precedent that we should be doing it for other parameters; so for now, i'm marking this as invalid.