backup-list-instance cmd doesn't validate instance id
Bug #1363060 reported by
Doug Shelley
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack DBaaS (Trove) |
Triaged
|
Low
|
Unassigned |
Bug Description
trove backup-list bogus-instance-id returns:
+----+-
| id | name | status | parent_id | updated |
+----+-
+----+-
I believe it should return something like this:
ERROR: No instance with an ID of 'bogus-instance-id' exists.
Changed in trove: | |
assignee: | nobody → Doug Shelley (0-doug) |
summary: |
- backup-list cmd doesn't validate instance id + backup-list-instance cmd doesn't validate instance id |
Changed in trove: | |
status: | New → Triaged |
importance: | Undecided → Low |
milestone: | none → kilo-1 |
Changed in trove: | |
milestone: | kilo-1 → kilo-2 |
Changed in trove: | |
milestone: | kilo-2 → kilo-3 |
Changed in trove: | |
milestone: | kilo-3 → next |
Changed in trove: | |
assignee: | Doug Shelley (0-doug) → Jian Xu (jianxuz) |
Changed in trove: | |
assignee: | Jian Xu (jianxuz) → nobody |
To post a comment you must log in.
Actually it doesn't look like a bug. API did what you've asked - filtered backups by instance id that doesn't exist. But i do agree, that we need to raise HTTP 404 Not Found for cases like this.
I've noticed that we didn't filtering by instance ID at all, /github. com/openstack/ python- troveclient/ blob/master/ troveclient/ v1/backups. py#L41- L51 /github. com/openstack/ trove/blob/ master/ trove/backup/ service. py#L35- L46
see https:/
and see https:/