Remove use of term 'slave' in replication support

Bug #1360310 reported by Greg Lucas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Nikhil Manchanda
python-troveclient
Fix Released
Medium
Greg Lucas

Bug Description

The initial commits for replication support used the term 'slave' in a number of places. For example, to create a replica the current parameter passed in the create call is "slave_of".

The review feedback for Change-Id: Ieca67f042c6bcb33f2a4de1acbb330d3eefc0600 (https://review.openstack.org/#/c/101771/) concluded that 'slave' is a MySQL-specific term and the more generic term 'replica' should be used instead.

We need to be consistent in the use of 'replica' in the visible APIs and CLI options.

Optionally we may also want to update the database schema as well so that the terminology is consistent throughout.

Revision history for this message
Greg Lucas (glucas-q) wrote :

This affects the pending Horizon change sets as well.

Changed in trove:
assignee: nobody → Greg Lucas (glucas-q)
description: updated
Changed in trove:
milestone: none → next
milestone: next → ongoing
milestone: ongoing → next
importance: Undecided → High
status: New → Triaged
Changed in trove:
milestone: next → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117881

Changed in trove:
assignee: Greg Lucas (glucas-q) → Nikhil Manchanda (slicknik)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-troveclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117925

Changed in python-troveclient:
assignee: nobody → Greg Lucas (glucas-q)
status: New → In Progress
Changed in trove:
assignee: Nikhil Manchanda (slicknik) → Greg Lucas (glucas-q)
Changed in trove:
assignee: Greg Lucas (glucas-q) → Nikhil Manchanda (slicknik)
Changed in python-troveclient:
importance: Undecided → Medium
milestone: none → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/117881
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=53f79f62552d60a6d1a92ffdea292c175466b4e5
Submitter: Jenkins
Branch: master

commit 53f79f62552d60a6d1a92ffdea292c175466b4e5
Author: Nikhil Manchanda <email address hidden>
Date: Fri Aug 29 13:38:40 2014 -0700

    Use 'replica' instead of 'slave'

    The term 'slave' is very mysql specific. Deprecate the API terminology
    that references 'slaves', and 'slave_of', and replace it with 'replicas',
    and 'replica_of' instead which is more applicable across datastores of
    different types.

    Co-Authored-By: Greg Lucas <email address hidden>
    Change-Id: Ief4bc83369fa3183a321d3e07b69b1801595ab15
    Closes-bug: 1360310

Changed in trove:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to trove (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/118521

Changed in python-troveclient:
assignee: Greg Lucas (glucas-q) → Nikhil Manchanda (slicknik)
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Changed in python-troveclient:
assignee: Nikhil Manchanda (slicknik) → Greg Lucas (glucas-q)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-troveclient (master)

Reviewed: https://review.openstack.org/117925
Committed: https://git.openstack.org/cgit/openstack/python-troveclient/commit/?id=b287f672ac650defda96939945192af6df452136
Submitter: Jenkins
Branch: master

commit b287f672ac650defda96939945192af6df452136
Author: Greg Lucas <email address hidden>
Date: Fri Aug 29 22:58:04 2014 -0400

    Use 'replica' instead of 'slave'

    Replace the mysql-specific term 'slave' with the more general term
    'replica'.

    In order to merge properly the client currently handles both 'slave' and
    'replica' in certain cases. The 'slave' support will be removed completely
    once the trove runtime is updated to be in sync.

    Change-Id: Id22d18a84a4ac104ff8af09959e8eb2ae0102e97
    Co-Authored-By: Nikhil Manchanda <email address hidden>
    Partial-Bug: 1360310

Doug Shelley (0-doug)
Changed in python-troveclient:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-3 → 2014.2
Zhao Chao (zhaochao1984)
Changed in python-troveclient:
milestone: juno-3 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.