When creating a replica for instance Trove doesn't valiate that master exists and is ACTIVE

[Denis M.]

User is able to create slave from non existing master.

Bug described here https://review.openstack.org/#/c/98147/23/trove/instance/models.py,cm

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/117222

[Nikhil Manchanda (slicknik)]

Not blocking for Juno RC.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nikhil Manchanda (<email address hidden>) on branch: master
Review: https://review.openstack.org/117222
Reason: Abandoning changes that are greater than 1 month old with a negative
review (and no new patchsets) as part of a regular clean up of
reviews. Please feel free to restore your change if this is still work
in progress.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163100

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163100
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=32387f8ffd3ba6e45064d675d2b18cb666397894
Submitter: Jenkins
Branch: master

commit 32387f8ffd3ba6e45064d675d2b18cb666397894
Author: Matt Van Dijk <email address hidden>
Date: Sat Mar 7 02:49:30 2015 -0500

    Fix replica source state validation

    Creating a replica did not check that the specified source was available.
    It is necessary that the source's state is active and that it is not busy.
    This is done by verifying the state and status of the master.

    The new checks will throw a HTTP 422 UnprocessableEntity in cases when the
    status is not ACTIVE or source is busy performing a task

    Changes:
     - adding validation step that checks if master exists and in proper state.
     - added appropriate API and unit tests

    Co-authored by: Denis Makogon <email address hidden>

    DocImpact

    Change-Id: Ib4e37ff0036998bc53058e400054ed93fcc2e144
    Closes-Bug: #1357704