OpenStack DBaaS (Trove)

Enable hacking check H306

Bug #1346387 reported by Christian Berendt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Wishlist
Christian Berendt
OpenStack DBaaS (Trove) ongoing

Bug Description

The hacking check H306 (imports not in alphabetical order) should be enabled.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/108417

Changed in trove:
assignee: nobody → Christian Berendt (berendt)
status: New → In Progress
Nikhil Manchanda (slicknik)
Changed in trove:
importance: Undecided → Wishlist
milestone: none → ongoing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by Christian Berendt (<email address hidden>) on branch: master
Review: https://review.openstack.org/108417
Reason: too old

Revision history for this message
Amrith Kumar (amrith) wrote :

This was fixed in https://review.openstack.org/#/c/181950/

Changed in trove:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
status: In Progress → Fix Committed
Revision history for this message
Amrith Kumar (amrith) wrote :

I'm not sure exactly when it was fixed but now H306 is certainly enabled in Trove. To verify I just switched the order of a couple of imports and ran tox

pep8 runtests: commands[0] | flake8
./trove/common/cfg.py:21:1: H306 imports not in alphabetical order (oslo_log.log, oslo_config.cfg)
from oslo_config import cfg
^

Doug Hellmann (doug-hellmann)
Changed in trove:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.