guestagent contract for packages should be a list

Bug #1341966 reported by Craig Vyvial
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Craig Vyvial

Bug Description

The RPC contract for the prepare call to the guest agent should be consistent.

the prepare call currently makes the call with a long string and the guest agent splits the string.

packages = "pkg1 pkg2 pkg3"

The prepare call for users and databases are a list of strings so the packages should really be the same.

users = ["user1", user2", "user3"]
databases = ["db1", "db2", "db3"]
packages = ["pkg1", "pkg2", "pkg3"]

Craig Vyvial (cp16net)
description: updated
Changed in trove:
assignee: nobody → Craig Vyvial (cp16net)
status: New → In Progress
Revision history for this message
Denis M. (dmakogon) wrote :

for backward compatibility i'd suggest to verify if 'packages' attribute is a 'list of strings' or 'string' and then act dependently on the type of attribute

Changed in trove:
importance: Undecided → Low
milestone: none → juno-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/104108
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=fc1ba31b427157b22dd84e022e36b9cb6a5e093e
Submitter: Jenkins
Branch: master

commit fc1ba31b427157b22dd84e022e36b9cb6a5e093e
Author: Craig Vyvial <email address hidden>
Date: Wed Jul 2 03:08:51 2014 -0500

    guestagent contract for packages should be a list

    the guestagent contract on the prepare call sends the packages to
    install as a long space delimited string and this should be a list. The
    other parameters are lists like users and databases. The packages should
    be a list as well.

    Closes-Bug: #1341966
    Change-Id: I05233bfce6d4b81351b797a30d3a55313edf277e

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.