guestagent config for datastore_registry_ext needs to be cleaner

Bug #1336626 reported by Craig Vyvial
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
In Progress
Medium
Unassigned

Bug Description

If you want to override the guestagent managers its looks really nasty to have EVERY manager on a single line here.

datastore_registry_ext = mysql:my.guestagent.datastore.mysql.manager.Manager,percona:my.guestagent.datastore.mysql.manager.Manager

This needs to be tidied up and split out some way.
Ideally each of these should be on a single line.

datastore_registry_ext = mysql:my.guestagent.datastore.mysql.manager.Manager
datastore_registry_ext = percona:my.guestagent.datastore.mysql.manager.Manager

or maybe...

datastores = mysql,precona
[mysql]
manager = my.guestagent.datastore.mysql.manager.Manager
[percona]
manager = my.guestagent.datastore.percona.manager.Manager

After typing out the second idea i dont like it as much as something like the first way.

DEV LIST THREAD: http://lists.openstack.org/pipermail/openstack-dev/2014-July/039145.html

Craig Vyvial (cp16net)
description: updated
Changed in trove:
importance: Undecided → Low
status: New → Triaged
Anna (annaphilips)
Changed in trove:
assignee: nobody → Anna (annaphilips)
Revision history for this message
Denis M. (dmakogon) wrote :

Not quite sure about which solution can be more user-friendly. But iirc, oslo.config allows to define custom attribute type.

Anna (annaphilips)
Changed in trove:
assignee: Anna (annaphilips) → nobody
Changed in trove:
assignee: nobody → Trevor McCasland (twm2016)
Changed in trove:
status: Triaged → In Progress
Revision history for this message
Amrith Kumar (amrith) wrote :

A change is in review now.

See: https://review.openstack.org/#/c/284434/

Changed in trove:
milestone: none → newton-1
importance: Low → Medium
Changed in trove:
assignee: Trevor McCasland (twm2016) → Amrith (amrith)
Amrith Kumar (amrith)
Changed in trove:
assignee: Amrith (amrith) → Trevor McCasland (twm2016)
Amrith Kumar (amrith)
Changed in trove:
milestone: newton-1 → ongoing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/284434
Reason: time to abandon based on the midcycle conversation re: refactor

Changed in trove:
assignee: Trevor McCasland (twm2016) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.