Backup remains in NEW/BUILD state even if guest exception appears or guest is deleted

[Denis M.]

Trove should mark failed backup with ERRO/FAILED status when guest exception appears.

Proposed fix should deal with next things:
1. Releave instance, reset task.
2. Mark backup as FAILED/ERROR.

Dependent issue:
https://bugs.launchpad.net/trove/+bug/1220989

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/102262

[Ramashri Umale (ramashri)]

Denis,

How can we reproduce this bug.

On the guest end:

BackupAgent.execute_backup all exceptions are caught and backup state is set to FAILED.

On the taskmanager end

create_backup makes a async cast so yes GuestError may be a possibility but no GuestTimeout should occur.

As such unless the case for GuestError can be reproduced, please explain need for this fix.

[Denis M. (dmakogon)]

Ramashri, easily

There are several ways to reproduce this bug:
1. Delete guest queue.
2. Network delay.
3. Remove guest completely.

SO, the simple answer - make AMPQ unreachable for guest.

[Amrith Kumar (amrith)]

Updating importance to "Low" (bugscrub, 2014-10-23)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Denis M. (<email address hidden>) on branch: master
Review: https://review.openstack.org/102262