Both ConfigurationView and DetailedConfigurationView for configuration-groups return only the Datastore Version ID and not human the readable Datastore Name / Version

[Nikhil Manchanda]

ConfigurationView
        configuration_dict = {
            "id": self.configuration.id,
            "name": self.configuration.name,
            "description": self.configuration.description,
            "datastore_version_id": self.configuration.datastore_version_id,
        }

DetailedConfigurationView
        configuration_dict = {
            "id": self.configuration.id,
            "name": self.configuration.name,
            "description": self.configuration.description,
            "values": values,
            "datastore_version_id": self.configuration.datastore_version_id,
        }

It would be nice to have the human readable datastore name, and version also returned.

Trove should return human-readable Datastore Name and Version Name for the next requests:

1. List configurations.
2. Show configuration by it's ID.
3. Create a new Configuration.

Shell output example for
 -list:

+----+------+-------------+----------------+------------------------+
| ID | Name | Description | Datastore Name | Datastore Version Name |
+----+------+-------------+----------------+------------------------+
+----+------+-------------+----------------+------------------------+

-show:

+------------------------+--------------------------------------+
| Property | Value |
+------------------------+--------------------------------------+
| datastore_name | mysql |
| datastore_version_name | 5.5 |
| description | None |
| id | 4912ebb4-8d9d-47dc-9026-799f9b76a7e1 |
| name | mysql |
| values | {"connect_timeout": 100} |
+----------------------+----------------------------------------+

-create

+------------------------+--------------------------------------+
| Property | Value |
+------------------------+--------------------------------------+
| datastore_name | mysql |
| datastore_version_name | 5.5 |
| description | None |
| id | 4912ebb4-8d9d-47dc-9026-799f9b76a7e1 |
| name | mysql |
| values | {"connect_timeout": 100} |
+----------------------+----------------------------------------+

[Denis M. (dmakogon)]

Would it be better to have both - version id and version human-readable name? Or only one of them ?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/98985

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/98985
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=905086fcadab213587d965352ea46302278d6fdd
Submitter: Jenkins
Branch: master

commit 905086fcadab213587d965352ea46302278d6fdd
Author: Denis Makogon <email address hidden>
Date: Tue Jun 10 12:23:04 2014 +0300

    Add datatore/version name into configurations response

    Reasons:
     - Both ConfigurationView and DetailedConfigurationView
       for configuration-groups return only the Datastore
       Version ID and not human the readable Datastore Name / Version

    Changes:
     - adding datastore version name to:
       - configuration-create;
       - configuration-list;
       - configuration show responses.
     - tests;

    Change-Id: I8fbefd57d40838dafcead0077bfbc6b49c27a8eb
    Closes-Bug: #1326584