audit logging levels

Bug #1324206 reported by Craig Vyvial on 2014-05-28
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Low
Sergey Gotliv

Bug Description

We need to audit the log levels for trove.

We need to go through each module and make sure we make levels useful to operations and support from the logs.

https://wiki.openstack.org/wiki/LoggingStandards

etherpad will help update everyone what the state of the modules are in.

https://etherpad.openstack.org/p/Juno-Trove-audit-logging-levels

Craig Vyvial (cp16net) on 2014-05-28
description: updated
Craig Vyvial (cp16net) on 2014-05-28
Changed in trove:
importance: Undecided → Low
Craig Vyvial (cp16net) on 2014-05-29
description: updated

Fix proposed to branch: master
Review: https://review.openstack.org/97996

Changed in trove:
assignee: nobody → Doug Shelley (0-doug)
status: New → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/98291

Changed in trove:
assignee: Doug Shelley (0-doug) → Simon Chang (changsimon)

Change abandoned by Simon Chang (<email address hidden>) on branch: master
Review: https://review.openstack.org/98291
Reason: Audit log code changes will be separated by module. Abandoning this commit.

Fix proposed to branch: master
Review: https://review.openstack.org/98546

Changed in trove:
assignee: Simon Chang (changsimon) → Doug Shelley (0-doug)

Fix proposed to branch: master
Review: https://review.openstack.org/102243

Fix proposed to branch: master
Review: https://review.openstack.org/103217

Changed in trove:
assignee: Doug Shelley (0-doug) → Amrith (amrith)

Reviewed: https://review.openstack.org/97996
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=e1f227c8e443bdf76dee34568df75f950c962748
Submitter: Jenkins
Branch: master

commit e1f227c8e443bdf76dee34568df75f950c962748
Author: Doug Shelley <email address hidden>
Date: Wed Jun 4 18:32:24 2014 -0400

    Logging audit for trove/backup module

    Adjust log messages to conform to logging standards.

    Change-Id: Id11f7fec952a7f9d4af3c4b40d3283d8871026d4
    Partial-Bug: #1324206

Reviewed: https://review.openstack.org/103953
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=1fc852b08c19369d4b4bbae970f5e7ee6e9df335
Submitter: Jenkins
Branch: master

commit 1fc852b08c19369d4b4bbae970f5e7ee6e9df335
Author: Amrith Kumar <email address hidden>
Date: Tue Jul 1 13:22:37 2014 -0400

    Logging audit for trove/db module

    Adjust log messages to conform to logging standards.
    Cleanup some messages that were unclear.

    Change-Id: I0a67acd6aa7bef8cb9adb32cf0f821ba24a4cb92
    Partial-Bug: #1324206

Change abandoned by Simon Chang (<email address hidden>) on branch: master
Review: https://review.openstack.org/98523

Changed in trove:
assignee: Amrith (amrith) → Simon Chang (changsimon)

Reviewed: https://review.openstack.org/103217
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=7d10989d41995548d1b9f32e1336881f00dbf3d7
Submitter: Jenkins
Branch: master

commit 7d10989d41995548d1b9f32e1336881f00dbf3d7
Author: Amrith Kumar <email address hidden>
Date: Fri Jun 27 14:58:50 2014 -0400

    Logging audit for trove/common module

    Adjust log messages to conform to logging standards.
    Cleanup some messages that were unclear.

    Change-Id: I0bed14a98477d7e2b83e43ce020b6b41e5ac8fa8
    Partial-Bug: #1324206

Fix proposed to branch: master
Review: https://review.openstack.org/107726

Changed in trove:
assignee: Simon Chang (changsimon) → Amrith (amrith)

Fix proposed to branch: master
Review: https://review.openstack.org/107732

Fix proposed to branch: master
Review: https://review.openstack.org/107739

Fix proposed to branch: master
Review: https://review.openstack.org/107774

Fix proposed to branch: master
Review: https://review.openstack.org/107787

Fix proposed to branch: master
Review: https://review.openstack.org/107788

Fix proposed to branch: master
Review: https://review.openstack.org/107795

Fix proposed to branch: master
Review: https://review.openstack.org/107805

Fix proposed to branch: master
Review: https://review.openstack.org/107806

Change abandoned by Simon Chang (<email address hidden>) on branch: master
Review: https://review.openstack.org/98546
Reason: Changes will be submitted in a new commit.

Fix proposed to branch: master
Review: https://review.openstack.org/108020

Changed in trove:
assignee: Amrith (amrith) → Simon Chang (changsimon)
Changed in trove:
assignee: Simon Chang (changsimon) → Amrith (amrith)
Changed in trove:
assignee: Amrith (amrith) → Simon Chang (changsimon)
Changed in trove:
assignee: Simon Chang (changsimon) → Amrith (amrith)
Changed in trove:
assignee: Amrith (amrith) → Simon Chang (changsimon)
assignee: Simon Chang (changsimon) → Amrith (amrith)

Reviewed: https://review.openstack.org/102243
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=6763a032a176d1b8a6ba32dfa1bf33bbcee74e35
Submitter: Jenkins
Branch: master

commit 6763a032a176d1b8a6ba32dfa1bf33bbcee74e35
Author: Doug Shelley <email address hidden>
Date: Tue Jun 24 10:05:24 2014 -0400

    Logging audit for trove/configuration module

    Adjust log messages to conform to logging standards.

    Change-Id: I16e48928d7a710e2ba31524be02d358b4e1dd713
    Partial-Bug: #1324206

Changed in trove:
assignee: Amrith (amrith) → Simon Chang (changsimon)
Changed in trove:
assignee: Simon Chang (changsimon) → Amrith (amrith)

Reviewed: https://review.openstack.org/107726
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=b668e85cb6d8d147fde22e2b43897ea2cc024db0
Submitter: Jenkins
Branch: master

commit b668e85cb6d8d147fde22e2b43897ea2cc024db0
Author: Amrith Kumar <email address hidden>
Date: Thu Jul 17 10:45:27 2014 -0400

    Logging audit for trove/guestagent module

    Adjust logging to conform to logging standards. Found
    and fixed a pattern of not logging exception information.
    Cleaned up some messages that were unclear.

    Also addressed a pattern of having exception's using
    LOG.error to log the exception (rather than using
    LOG.exception).

    Change-Id: Idab510051321f4f9ed096c9972322530028ad2e6
    Partial-Bug: #1324206

Reviewed: https://review.openstack.org/107732
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=324702ec35c2d812eb33f6264616d0b0843d9864
Submitter: Jenkins
Branch: master

commit 324702ec35c2d812eb33f6264616d0b0843d9864
Author: Amrith Kumar <email address hidden>
Date: Thu Jul 17 11:02:59 2014 -0400

    Logging audit for trove/guestagent/backup module

    Adjust logging to conform to logging standards.
    Cleaned up some messages that were unclear. Also
    corrected the usage of the word Backup which was
    inconsistently capitalized in some messages.

    Also addressed a pattern of exception handlers using
    LOG.error merely to log the exception (instead of
    using LOG.exception)

    Change-Id: Id2eb57d3395273f9aebd41de0146f7a2fc2774c8
    Partial-Bug: #1324206

Reviewed: https://review.openstack.org/107739
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=02c4eb9d3cbd4b4602948e689a5d1af6958cdea1
Submitter: Jenkins
Branch: master

commit 02c4eb9d3cbd4b4602948e689a5d1af6958cdea1
Author: Amrith Kumar <email address hidden>
Date: Thu Jul 17 11:10:23 2014 -0400

    Logging audit for trove/guestagent/datastore module

    Adjust logging to conform to logging standards.
    Cleaned up some messages that were unclear.

    Change-Id: I2136a95b07ac80e86207447e6a6f33b839df2f16
    Partial-Bug: #1324206

Reviewed: https://review.openstack.org/107788
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=0d163bffe18b2ab319702d8135d18643167e2a70
Submitter: Jenkins
Branch: master

commit 0d163bffe18b2ab319702d8135d18643167e2a70
Author: Amrith Kumar <email address hidden>
Date: Thu Jul 17 14:23:49 2014 -0400

    Logging audit for guestagent/couchbase

    Adjust logging to conform to logging standards.
    Cleaned up a few messages that were unclear, and
    added some debug messages for recently added
    API stubs.

    Fixed a pattern of using LOG.error in exception handlers
    merely to log the exception (instead of using
    LOG.exception)

    Change-Id: I4ed452ddc4e0e9a29f6cbcc9d4e04f3a8b183687
    Partial-Bug: #1324206

Reviewed: https://review.openstack.org/107787
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=cf7694f0dbf9b5f81057f00c35cfe626f22a71ec
Submitter: Jenkins
Branch: master

commit cf7694f0dbf9b5f81057f00c35cfe626f22a71ec
Author: Amrith Kumar <email address hidden>
Date: Thu Jul 17 14:07:35 2014 -0400

    Logging audit for guestagent/cassandra

    Adjust logging to conform to logging standards.
    Cleaned up some messages that were unclear and
    changed many messages from LOG.info to LOG.debug.

    Fixed a pattern of exception handlers using LOG.error
    to log the exception (instead of LOG.exception)

    Change-Id: I828fbb38b6bf6eb36c349d83475ca46c28779225
    Partial-Bug: #1324206

Reviewed: https://review.openstack.org/107774
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=fe2f755a3bdf75838b1c0b788cb8aa764103fcbd
Submitter: Jenkins
Branch: master

commit fe2f755a3bdf75838b1c0b788cb8aa764103fcbd
Author: Amrith Kumar <email address hidden>
Date: Thu Jul 17 12:53:36 2014 -0400

    Logging audit for guestagent/strategies module

    Adjust logging to conform to logging standards.
    Cleaned up some messages that were unclear. Changed
    some messages from info to debug if they are
    benign and expected.

    Change-Id: Ibc79699bd3fbe9528c67566acdc683b33ac23f3f
    Partial-Bug: #1324206

Reviewed: https://review.openstack.org/107806
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=104850e7159d95031d62e62a6119de16e3ba893e
Submitter: Jenkins
Branch: master

commit 104850e7159d95031d62e62a6119de16e3ba893e
Author: Amrith Kumar <email address hidden>
Date: Thu Jul 17 15:12:23 2014 -0400

    Logging audit for trove/mysql module

    Adjust logging to conform to logging standards.
    Cleaned up a few messages that are unclear and
    changed some LOG.info messages to LOG.debug.

    Also fixed a pattern of having an exception with
    the sole purpose of logging an error with the
    value thrown and replaced with LOG.exception
    instead.

    Added LOG.debug messages to the mount, unmount
    and resize methods in service.py; this change
    was made to all datastores.

    Change-Id: If2a5c95b806e555d077ce494f474d3463fda6794
    Partial-Bug: #1324206

Changed in trove:
assignee: Amrith (amrith) → Simon Chang (changsimon)

Reviewed: https://review.openstack.org/108020
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=b5fc1a5519713f400335d592d0cf71379330e438
Submitter: Jenkins
Branch: master

commit b5fc1a5519713f400335d592d0cf71379330e438
Author: Simon Chang <email address hidden>
Date: Fri Jul 18 09:54:32 2014 -0400

    Adjusted audit logging for taskmanager module

    The taskmanager module audit log messages are unclear, some debug
    messages are supposed to be info and vice versa.

    Changed logging of various messages to conform to standard.

    Change-Id: Idaa46b67096c1fbbacdf730c06c823aaf3e1e255
    Partial-Bug: #1324206

Changed in trove:
assignee: Simon Chang (changsimon) → Amrith (amrith)

Reviewed: https://review.openstack.org/105294
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=a99b787cc24301fea472dd2d997e66369a40db75
Submitter: Jenkins
Branch: master

commit a99b787cc24301fea472dd2d997e66369a40db75
Author: Simon Chang <email address hidden>
Date: Mon Jul 7 18:37:57 2014 -0400

    Adjusted audit logging for trove.instance module

    The trove.instance module is logging some verbose debug data at the
    info level, and some info messages at the debug level. Some log
    entries are also lacking context because of missing identifiers such
    as InstanceID and TenantID.

    Changed logging level of various messages to conform to standard,
    added references to various ID's as needed.

    Change-Id: I3bb569529befa2b2497d2d5a094e3306e569422c
    Partial-Bug: #1324206

Reviewed: https://review.openstack.org/107795
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=42c4825baa424b926f227108cd6d01c5b01d9509
Submitter: Jenkins
Branch: master

commit 42c4825baa424b926f227108cd6d01c5b01d9509
Author: Amrith Kumar <email address hidden>
Date: Thu Jul 17 14:40:47 2014 -0400

    Logging audit for guestagent/mongodb

    Adjust logging to conform to logging standards.
    Cleaned up a few messages that were unclear and changed several
    LOG.info messages to LOG.debug.

    Also fixed a pattern of exception handlers using LOG.error
    merely to log the exception (instead of LOG.exception)

    Change-Id: I3bd544b761b449d1181792ff498f9c171331df16
    Partial-Bug: #1324206

Reviewed: https://review.openstack.org/107805
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=5b0f26aac261eb5cd5bc81f687f2175ff84097c0
Submitter: Jenkins
Branch: master

commit 5b0f26aac261eb5cd5bc81f687f2175ff84097c0
Author: Amrith Kumar <email address hidden>
Date: Thu Jul 17 15:17:37 2014 -0400

    Logging audit for guestagent/redis

    Adjust logging to conform to logging standards.
    Cleaned up a few messages that were unclear and changed some
    LOG.info messages to LOG.debug

    Change-Id: I3570dddf0ba7c576b4cf9cb6affa55335fd23ac7
    Partial-Bug: #1324206

Fix proposed to branch: master
Review: https://review.openstack.org/133670

Changed in trove:
assignee: Amrith (amrith) → Sergey Gotliv (sgotliv)
Changed in trove:
milestone: none → ongoing

Reviewed: https://review.openstack.org/133670
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=27c2e6c1cbb5240a4aced9785a5b46b60d1b4bd3
Submitter: Jenkins
Branch: master

commit 27c2e6c1cbb5240a4aced9785a5b46b60d1b4bd3
Author: Sergey Gotliv <email address hidden>
Date: Tue Nov 11 14:24:20 2014 +0200

    Add few audit log messages to guestagent module

    Few APIs were still missing log messages before calling RPC layer while
    few others had multiple debug messages which I've squashed into single
    log message.

    Partial-Bug: #1324206

    Change-Id: Ic6df12eb25497bfb39ea1506e41a37ba632e713c

Amrith Kumar (amrith) wrote :

A number of changes were made over two years ago but all of them were tagged as "partial-bug" and therefore this never got marked as done!

Changed in trove:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers