unknown method ExtensionManager called in trove.common.extensions

Bug #1323400 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Wishlist
Sushil Kumar

Bug Description

https://github.com/openstack/trove/blob/master/trove/common/extensions.py#L47 calls ExtensionManager(CONF.api_extensions_path)

But there is no such method available inside the module.
System does not gives any error for this code because it never goes to second condition, as first condition is always evaluating True in our case.

Rather the correct method is extensions.ExtensionManager

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/95577

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Changed in trove:
importance: Undecided → Low
importance: Low → Wishlist
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/95577
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=e1750808398e6ea591101fa422ba54d47d7795fb
Submitter: Jenkins
Branch: master

commit e1750808398e6ea591101fa422ba54d47d7795fb
Author: SushilKM <email address hidden>
Date: Mon May 26 19:35:03 2014 +0000

    Corrects the class name "ExtensionManager"

    Corrects ExtensionManager to extensions.ExtensionManager which was
    earlier written without the package name.

    There were no errors encountered as first condition of the condition set
    always evaluated True.

    Change-Id: I1fd4016105a99a7baaad6d2613b0e709a09aeeb2
    Closes-Bug: #1323400

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.