trove configuration-update bug

[Khyati Sheth]

A bug exists in trove configuration-update workflow.

Consider mysql configuration group for example. If an existing configuration group consists of values like
{"autocommit": 1, "max_connections": 100, "max_user_connection": 100}. Assume this config group is already applied to a mysql instance "MysqlConfigTest".

If we update this config group to {"autocommit": 1} i.e trove configuration-update <config-group> {"autocommit": 1}, this new config group is updated in "MysqlConfigTest" instance. However, the values for "max_connections": 100, "max_user_connection": 100 are not reset to reflect either their corresponding values in my.cnf or the default mysql values.

This holds because the instance state does not flip to "RESTART_REQUIRED", for trove configuration-update. If any keys are removed from the existing configuration group, the instance should flip to "RESTART_REQUIRED".

Proposed Solution:

Solution is to check that the subset condition. If existing configuration group keys are not a subset of the new keys proposed in configuration-update <config_group> <key/values>, then the instance should flip to RESTART_REQUIRED.

[Auston McReynolds (amcrn)]

this was fixed by a prior bugfix. marked as "fix released"