execute_with_timeout in utils.py can throw UnknownArgumentError when timeout is passed in kwargs

[Viswa Vutharkar]

At https://github.com/openstack/trove/blob/master/trove/common/utils.py#L274 if the caller supplied a 'timeout' param as one of the kwargs, because the 'timeout' arg is not being popped ( a 'get' is done instead) here, when further down the call stack
https://github.com/openstack/trove/blob/master/trove/openstack/common/processutils.py#L121 gets executed, an UnknownArgumentError exception is thrown.

This does not manifest normally, because callers of utils.py:: execute_with_timeout don't normally seem to pass in a 'timeout' kwarg. But in some cases where the caller knows that the default value of 30 secs may not be enough timeout, and decides to pass in a kwarg param timeout=xx, then it blows up.

Fix is very simple, just replace the 'get' with 'pop'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80677

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/80677
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=d9383e661c39f3f80cfce0227d033303b3c74bc5
Submitter: Jenkins
Branch: master

commit d9383e661c39f3f80cfce0227d033303b3c74bc5
Author: Viswa Vutharkar <email address hidden>
Date: Fri Mar 14 15:02:04 2014 -0500

    Pop instead of get for timeout kwarg

    In utils.py execute_with_timeout() method was updated
    to do kwargs.pop() instead of kwargs.get()

    Closes-Bug: #1292692
    Change-Id: Id69e66f5e312a2bd2501bae18ddd050dd4296ff5